Repository navigation
TEST: consolidate reconstruction regressions and cover numerical steps - #109
Merged
Merged
Conversation
Keep one comprehensive e2e case per reconstructor and replace overlapping reconstructions with inline numerical and shared-feature tests. Validation: 1707 unit tests and six e2e tests pass. The retained DM e2e reproduces its pre-existing reference mismatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features/fixes
Overlapping full reconstructions make the test suite expensive. Reduce 51 saved-reference cases to six comprehensive e2e cases covering LSQML, AD, BH, ePIE, DM, and rPIE, and retain the synthetic RAAR e2e case. Rename their files and test methods with the
_e2esuffix and register ane2emarker for separate runs.Replace redundant reconstructions with inline numerical and shared-feature tests covering reciprocal projection, LSQML accumulation and least-squares steps, AD gradients and scheduling, BH and PIE updates, position correction, constraints, low-memory forward models, data placement, and distributed reduction. Keep the shared
make_taskhelper intests/test_utils.pyand restrict gold generation to retained saved-reference tests.The six retained saved-reference reconstruction bodies match main by AST comparison; their reference keys and tolerances are preserved.
Validation
test_utils.py: 112 affected tests passed.test_utils.pyretains four existing unused imports.Commands:
uv run --locked --with torch==2.12.1 --with torchvision pytest --high-tol -m 'not e2e'and the same command with-m e2e.Mentions
No reviewers requested.
Checklist (Don't skip!)