Skip to content

CI: version test reference data with DVC - #110

Merged
mdw771 merged 1 commit into
mainfrom
ci
Nov 16, 2026
Merged

mdw771 merged 1 commit into
mainfrom
ci

Conversation

@mdw771

@mdw771 mdw771 commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Features/fixes

CI previously pulled the latest test data independently of the code revision, so updating a PR's golden outputs could affect tests on main. Track inputs and golden outputs with DVC pointers committed alongside the code, allowing each revision to select its own data.

  • Fetch data from an SSH remote configured through the PTYCHO_CI_DATA_URL repository secret.
  • Keep the DVC cache outside the checkout so it survives cleanup, with an optional PTYCHO_CI_CACHE_DIR override.
  • Default local tests to tests/reference and warn when PTYCHO_CI_DATA_DIR overrides that location.
  • Move testing and reference-update instructions to tests/README.rst.

Validation

  • GitHub Actions passed on 59dd04f.
  • A fresh remote download matched all 63 migrated input and golden-output files by SHA-256; all 7 e2e tests passed locally with PyTorch 2.12.1 and CI tolerances.
  • Verified cache reuse across checkout cleanup and data versions A → B → A, including restoration with the remote unavailable. Checked automatic and overridden cache paths, and the legacy data-path warning.

Mentions

No specific reviewer requested.

Checklist (Don't skip!)

  • Formatted your code properly adhering to PEP-8?
  • Cleaned up your code to remove large commented-out blocks? No new commented-out code.
  • Properly documented any new API knobs and functions with non-trivial signatures?
  • Resolved all merge conflicts with the main branch?
  • Checked the diffs between your branch and the main branch to ensure that your changes are not introducing any regressions or unnecessary/irrelevant changes?
  • Checked the diffs to ensure your PR only includes one feature/fix?
  • Added unit tests for new features if necessary? Configuration and migration behavior were verified directly; no new permanent unit tests were needed.

@mdw771
mdw771 merged commit 5715cf8 into main Nov 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant