Skip to content

fix for TV chambolle which is correct for real but not for complex - #111

Merged
mdw771 merged 1 commit into
mainfrom
TV_2d_chambolle_fix_complex_valued
Nov 17, 2026
Merged

mdw771 merged 1 commit into
mainfrom
TV_2d_chambolle_fix_complex_valued

Conversation

@a4894z

@a4894z a4894z commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Features/fixes

The existing version of Chambolle TV regularization is correct only for real valued images; for complex valued the computed norm of the gradient is complex which is wrong. I've introduced a fix for this. Also, the final scaling of the image after applying TV needs to be modified for complex valued images.

Ming mentioned something in teams chat saying that the for loop should be using the original image rather than modifying it...I haven't tried this yet, just FYI

TV_chambolle

Related issues (optional)

N/A

Mentions

N/A

Checklist (Don't skip!)

Have you...

  • Formatted your code properly adhering to PEP-8? Considering using RUFF to format your code automatically (https://docs.astral.sh/ruff/installation/).
  • Cleaned up your code to remove large commented-out blocks?
  • Properly documented any new API knobs and functions with non-trivial signatures?
  • Resolved all merge conflicts with the main branch?
  • Checked the diffs between your branch and the main branch to ensure that your changes are not introducing any regressions or unnecessary/irrelevant changes?
  • Checked the diffs to ensure your PR only includes one feature/fix? Multiple features/fixes/changes should be split into different PRs.
  • Added unit tests for new features if necessary?

@a4894z
a4894z requested a review from mdw771 November 16, 2026 22:48
@mdw771
mdw771 merged commit 9959447 into main Nov 17, 2026
2 checks passed
@mdw771
mdw771 deleted the TV_2d_chambolle_fix_complex_valued branch November 17, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants