Repository navigation
fix for TV chambolle which is correct for real but not for complex - #111
Merged
Merged
Conversation
mdw771
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features/fixes
The existing version of Chambolle TV regularization is correct only for real valued images; for complex valued the computed norm of the gradient is complex which is wrong. I've introduced a fix for this. Also, the final scaling of the image after applying TV needs to be modified for complex valued images.
Ming mentioned something in teams chat saying that the for loop should be using the original image rather than modifying it...I haven't tried this yet, just FYI
Related issues (optional)
N/A
Mentions
N/A
Checklist (Don't skip!)
Have you...