Repository navigation
REFACTOR: move magnitude projection into noise models - #113
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features/fixes
PIE, MAGPIE, DM, and RAAR now use the shared noise model for propagated magnitude projection and magnitude MSE loss. The projection uses an identity detector on the wave grid when called without a forward model. LSQML keeps its existing Gaussian and Poisson loss behavior. DM and RAAR retain their exit-wave convergence diagnostics.
Validation included 470 regression tests before the optional argument change, including GPU reconstructions, and 142 targeted tests after it, including exact agreement with the explicit identity-detector projection.
Checklist