Skip to content

REFACTOR: move magnitude projection into noise models - #113

Merged
mdw771 merged 1 commit into
mainfrom
forward_model_refactor
Nov 17, 2026
Merged

mdw771 merged 1 commit into
mainfrom
forward_model_refactor

Conversation

@mdw771

@mdw771 mdw771 commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Features/fixes

PIE, MAGPIE, DM, and RAAR now use the shared noise model for propagated magnitude projection and magnitude MSE loss. The projection uses an identity detector on the wave grid when called without a forward model. LSQML keeps its existing Gaussian and Poisson loss behavior. DM and RAAR retain their exit-wave convergence diagnostics.

Validation included 470 regression tests before the optional argument change, including GPU reconstructions, and 142 targeted tests after it, including exact agreement with the explicit identity-detector projection.

Checklist

  • Checked formatting and cleaned up the changes.
  • Documented the new projection method and its arguments.
  • Checked the diff against the branch base for unrelated changes and regressions.
  • Added numerical regression coverage.

@mdw771
mdw771 merged commit 6061b1d into main Nov 17, 2026
2 checks passed
@mdw771
mdw771 deleted the forward_model_refactor branch November 17, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant