Write a measurement id into every file - #51
Open
micahjohnson150 wants to merge 3 commits into
Open
Conversation
Generated in write_probe_data rather than getProbeHeader, because it names one measurement rather than describing the probe, and getProbeHeader is called from places that are not writing a file. The id is seeded first so it reads at the top of the header, but extra_meta is applied over the top. That ordering is what lets a caller rewriting an existing measurement pass the original id through and keep it -- renaming a file that has already been uploaded would make the copy on disk and the copy in the cloud stop being the same measurement. Shares the key and the generator with study_lyte rather than restating them. Three clients write this format independently and the sync API keys on it, so there should be exactly one definition of how it is spelled. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated in write_probe_data rather than getProbeHeader, because it names one measurement rather than describing the probe, and getProbeHeader is called from places that are not writing a file.
The id is seeded first so it reads at the top of the header, but extra_meta is applied over the top. That ordering is what lets a caller rewriting an existing measurement pass the original id through and keep it -- renaming a file that has already been uploaded would make the copy on disk and the copy in the cloud stop being the same measurement.
Shares the key and the generator with study_lyte rather than restating them. Three clients write this format independently and the sync API keys on it, so there should be exactly one definition of how it is spelled.