Reject ambiguous transcript source options - #18
Open
vsolano9 wants to merge 1 commit into
Open
Conversation
Reject simultaneous --file and --dir options, fail cleanly for a missing file, and name the selected source when no runs are found. Add real CLI regression coverage and update the documented test count.
|
Welcome, @vsolano9, and thanks for your first pull request to Agentrace. A quick look at CONTRIBUTING.md covers how things are set up and run here. I'll review this shortly. Ask anything in the thread if something is unclear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Passing both
--fileand--dirsilently analyzes only the file, while empty and missing-file paths report misleading sources. This makes the input selection unambiguous at argparse’s boundary and keeps errors honest.Closes #8
Changes
--fileand--dirin one mutually exclusive argparse group--filewith a clean exit-2 parser error and no tracebackValidation
pytest -q— 22/22 pass; repeated successfully 20 consecutive timeslistandstats --jsonsmoke commands — passpip check— passgit diff --check— passChecklist