Normalize bounded read-tool limits consistently - #6
Open
vsolano9 wants to merge 1 commit into
Open
Conversation
Truncate finite numeric limits before applying the existing 1-50 clamp and route all non-finite values to the default. Document the behavior in both tool schemas and prove Shopify/database connectors receive identical normalized integers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Current
mainalready sends bothshopify_ordersanddb_querythrough the sameclampInthelper, so the issue’s 1000/-5/NaN examples are no longer raw at the connectors. The remaining hole is numeric fractions and infinities:1.9reaches both URLs unchanged, while positive/negative infinity become opposite bounds. This completes the existing centralized clamp contract.Closes #4
Changes
npm testValidation
1.9; positive infinity became 50 and negative infinity became 1npm test— 10/10 pass; repeated successfully 20 consecutive timesnpm run typecheck— passnpm ci— passnpx wrangler deploy --dry-run— pass; no deploymentgit diff --check— passChecklist