fix(scorer): report invalid schema patterns - #22
Open
vsolano9 wants to merge 1 commit into
Open
Conversation
Catch JSON Schema pattern compilation failures and return a path-attributed validation error instead of aborting the evaluation run. Cover nested invalid patterns and preserve valid mismatch behavior.
|
Welcome, @vsolano9, and thanks for your first pull request to Evalgate. A quick look at CONTRIBUTING.md covers how things are set up and run here. I'll review this shortly. Ask anything in the thread if something is unclear. |
Author
|
Postflight note on the red
This PR does not change the action or workflow; the failing context is the existing fork-comment permission path, not a scorer/test regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Convert an invalid user-supplied JSON Schema
patternfrom an uncaughtSyntaxErrorinto a normal failing scorer result. The error now includes the exact JSON path, pattern, and runtime compilation message, so one malformed schema cannot abort the entire eval run.Closes #8
Changes
validate()$.accountinvalid pattern through the real scorerValidation
npm run typechecknpm run lintnpm run buildnpm test— 9 files, 70 tests passednpm pack --dry-runand clean installed-tarball publicvalidateJsonSchemasmoke passedgit diff --checkChecklist
Closes #8Notes
Fresh install reports seven existing development-dependency advisories; production dependencies report zero, and this PR changes neither manifest nor lockfile.