fix(rule): separate URI and metadata secret signals - #21
Open
vsolano9 wants to merge 1 commit into
Open
Conversation
Keep sensitive resource URIs critical while preventing generic words in names or descriptions from creating false critical findings. Preserve unambiguous secret-file metadata references as medium-confidence findings and cover all three boundaries. Closes AgentPostmortem#9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9.
MCP030 now treats a resource URI as the strong signal: the complete sensitive-path pattern set still yields a critical finding there. Generic words in
nameordescriptionno longer create a false critical, while unambiguous filename/path references such as.env, private-key filenames, and/etc/passwdremain visible as medium-confidence findings.The rule description now states that confidence split, and regression coverage pins all three boundaries: negated generic prose, concrete metadata filenames, and sensitive URIs.
Validated locally:
git diff --checkFresh production audit reports the same two existing transitive advisories; this PR changes no dependency or lockfile.