Reject empty evaluation runs before database access - #4
Open
vsolano9 wants to merge 1 commit into
Open
Conversation
Reject zero-case CI submissions before any database access and document the constraint in the informational endpoint. Add a request-level regression test that runs without database credentials.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
An empty evaluation currently reaches the database and can be stored as a zero-case passing run. This rejects
results: []at the request boundary so a broken CI producer cannot report a false-green gate.Closes #3
Changes
resultsarray before initializing SupabaseGET /api/runsresponseValidation
npm test— pass; repeated successfully 20 consecutive timesnpx tsc --noEmit— passnpm run build— passgit diff --check— passnpm ci— pre-existing failure: the committed lockfile no longer satisfies the ranged versions inpackage.jsonnpm run lint— pre-existing failure:next lintis no longer a supported Next.js commandChecklist