Surface dropped_citations in /ask API response and CLI - #18
Merged
royalpinto007 merged 1 commit intoAug 11, 2026
Merged
Conversation
|
Welcome, @kaminimangal, and thanks for your first pull request to VaultRAG. A quick look at CONTRIBUTING.md covers how things are set up and run here. I'll review this shortly. Ask anything in the thread if something is unclear. |
|
Merged, @kaminimangal. Thank you for taking the time. Good, focused change. Exactly the kind of thing VaultRAG needs. If VaultRAG is useful to you, a star goes a long way. Happy to see more from you whenever you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
dropped_citationswas already being calculated ingenerate.pywhenever the model cited a source that wasn't actually given to it, but it never made it out anywhere — not in the API response, not in the CLI. So if the model hallucinated a citation, there was no way to actually see that it happened (unless every single citation was fake, which triggers a full refusal already).Changes
dropped_citationstoAskResponseinmain.pyand passed it through in the/askendpoint_askwhen there are dropped citations, same style as the existing conflict/stale warningsRan the full suite locally, everything passes (58 tests).
Closes #4
Checklist
Closes #123)