fix(eval): score unknown principals consistently - #20
Open
vsolano9 wants to merge 1 commit into
Open
Conversation
Score an unresolvable principal as perfect recall only when no documents were expected, while preserving a miss when expected documents exist. Remove the dead optionality filter and cover both boundaries with real-database regression tests. Closes AgentPostmortem#8
|
Welcome, @vsolano9, and thanks for your first pull request to VaultRAG. A quick look at CONTRIBUTING.md covers how things are set up and run here. I'll review this shortly. Ask anything in the thread if something is unclear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8.
An unresolvable principal now receives recall
1.0only when no documents were expected and0.0when expected documents are missing.mean_recallalso drops the impossibleis not Nonefilter, keeping the declaredfloattype and aggregation behavior aligned.Regression coverage exercises both unknown-principal boundaries against the real PostgreSQL/pgvector fixture.
Validated locally:
compileallandgit diff --checkRuff reports no patch-introduced lint or format delta: the single SIM103 finding and existing formatting drift are identical on upstream
main.