feat: locale packs so non-English calls are not silent passes - #10
feat: locale packs so non-English calls are not silent passes#10AshSgDe29071999 wants to merge 1 commit into
Conversation
Hardcoded English vocabularies made Spanish/Hindi calls look clean. Load packs from locale_packs/, default en (same pairs/phrases as before), and emit locale_unavailable instead of an empty pass when no pack exists. Ships an es example with a fixture. Fixes AgentPostmortem#3
There was a problem hiding this comment.
Locale packs are the right call, and locale_unavailable at high severity instead of an empty result is better than I would have asked for. Verified: language=hi gives [(locale_unavailable, high)], en clean call gives nothing.
Same matching bug as #9, written independently here:
FLAGGED "I ordered fifteen items for fifty pounds" <- transcript == truth
FLAGGED "we have thirteen in stock and thirty on order" <- transcript == truth
Only the -teen/-ty pairs are in en today so it is rare, but once #9 adds to/two and a/eight it fires constantly.
Suggest landing this one first with a positional matcher (difflib opcodes, pairs taken from the pack), then rebasing #9 so it only adds pairs and a fixture. One matcher, one place.
royalpinto007
left a comment
There was a problem hiding this comment.
Missing locale packs currently stop all analysis, hiding language-independent findings like policy violations, latency, and incomplete calls. Please add locale_unavailable, skip only locale-dependent checks, and continue running the others.
Summary
Mishearing and confirmation vocabularies were hardcoded English. A Spanish or Hindi call returned empty findings from the two most important checks — the same silent-pass shape this project exists to catch.
Changes
Test plan
Fixes #3