perf(r2): reuse validated S3 client - #96
Open
vsolano9 wants to merge 1 commit into
Open
Conversation
Memoize the lazily constructed Cloudflare R2 client and fail with a readable, variable-specific error before signing when required configuration is absent. Add coverage for reuse across upload/read presigns and every required variable. Closes AgentPostmortem#45
|
Welcome, @vsolano9, and thanks for your first pull request to agentpostmortem. A quick look at CONTRIBUTING.md covers how things are set up and run here. I'll review this shortly. Ask anything in the thread if something is unclear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45
What changed
S3Clientfor upload and read presignsValidation
npx vitest run— 14 files, 126 tests passednpx tsc --noEmitnpm run lint— no warnings or errorsnpx prettier --check .npm run buildwith the CI placeholder environmentNo dependency or lockfile changes.