Skip to content

fix(search): use canonical severity labels #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vsolano9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(search): use canonical severity labels #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions components/post/SearchResults.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,19 @@ import { useState, useEffect, useRef } from "react";
import Link from "next/link";
import { PostCard } from "@/components/post/PostCard";
import { AGENTS } from "@/lib/constants/agents";
import {
isSeverityLevel,
SEVERITY_LABELS,
type SeverityLevel,
} from "@/lib/constants/severity";
import type { Post } from "@/types";
import { ChevronDownIcon, ChevronUpIcon } from "@/components/ui/icons";

interface SearchResponse {
posts?: Post[];
}

const SEVERITY_LABELS: Record<number, string> = {
1: "Minimal",
2: "Low",
3: "Moderate",
4: "Severe",
5: "Critical",
};
const SEVERITY_LEVELS: SeverityLevel[] = [1, 2, 3, 4, 5];

export function SearchResults({
initialQuery,
Expand All @@ -28,8 +27,8 @@ export function SearchResults({
}) {
const [query, setQuery] = useState(initialQuery);
const [agentFilter, setAgentFilter] = useState("");
const [minSeverity, setMinSeverity] = useState(1);
const [maxSeverity, setMaxSeverity] = useState(5);
const [minSeverity, setMinSeverity] = useState<SeverityLevel>(1);
const [maxSeverity, setMaxSeverity] = useState<SeverityLevel>(5);
const [filtersOpen, setFiltersOpen] = useState(false);

const [results, setResults] = useState<Post[]>(initialResults);
Expand Down Expand Up @@ -211,7 +210,7 @@ export function SearchResults({
aria-labelledby="filter-severity-label"
className="flex gap-1"
>
{[1, 2, 3, 4, 5].map((lvl) => {
{SEVERITY_LEVELS.map((lvl) => {
const inRange = lvl >= minSeverity && lvl <= maxSeverity;
return (
<button
Expand All @@ -231,9 +230,15 @@ export function SearchResults({
setMinSeverity(1);
setMaxSeverity(5);
} else if (lvl === minSeverity) {
setMinSeverity(lvl + 1);
const nextLevel = lvl + 1;
if (isSeverityLevel(nextLevel)) {
setMinSeverity(nextLevel);
}
} else if (lvl === maxSeverity) {
setMaxSeverity(lvl - 1);
const previousLevel = lvl - 1;
if (isSeverityLevel(previousLevel)) {
setMaxSeverity(previousLevel);
}
} else {
setMinSeverity(lvl);
setMaxSeverity(lvl);
Expand Down