Fix UNION with nested SELECT - #2518
Open
pratyushsinghal7 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1264
Summary
Queries like
SELECT * FROM (SELECT *, (SELECT COUNT(*) FROM ?) AS c FROM ? UNION CORRESPONDING SELECT * FROM ?)crashed withCannot read property '0' of undefined, as did scalar subqueries nested inside another subquery's WHERE clause.The parser hoists every parenthesized scalar subquery into a single statement-level
querieslist, and the compiled expressions referencethis.queriesfn[queriesidx - 1]on their own query object — but only the outermost query ever received the compiled list, so any subquery reference evaluated inside a FROM subselect or inside another subquery foundthis.queriesfnundefined.queriesfnlist with nested compiled queries incompileQueriesand with FROM subselects, soqueriesidxreferences resolve at any nesting depthdirtyColumns(e.g.SELECT *over parameter data), so the outerSELECT *expands from the data instead of projecting only the statically known columnsTesting
bun test --preload ./test/bun-setup.js ./test/test1264.js(6 passed)bun run test-only(2194 passed, 213 skipped, 0 failed)bun x prettier --check src/40select.js src/420from.js test/test1264.js