Skip to content

Account for automatic poison coverage from equipped Deadly Brew - #7

Merged
AlexAllocated merged 1 commit into
mainfrom
codex/all-clients
Sep 25, 2026
Merged

AlexAllocated merged 1 commit into
mainfrom
codex/all-clients

Conversation

@AlexAllocated

Copy link
Copy Markdown
Owner

An equipped Deadly Brew rune provides automatic poison coverage on otherwise unpoisoned weapons. Read the equipped chest engraving through the documented Classic API and recognize enchant 6708, verified against the pinned Era spell/enchant records. Do not confuse knowing the engraving recipe with wearing the rune. Unknown rune observations stay quiet.

Add RUNE_UPDATED handling, a private regression and a dedicated SoD startup/transition smoke profile. Update 1.2.0 release documentation before its tag is published.

Validation: 141 tests in both orders under Lua 5.1/5.2; all seven NoPoizen client/ruleset smoke profiles on both; Lua parsing; four Python packaging/source checks; diff checks. Source and offline evidence only; no live SoD claim.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T02:10:07.935006Z 7308075 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AlexAllocated
AlexAllocated merged commit 67b99bc into main Sep 25, 2026
4 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7308075899

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread WeaponPoisons.lua
end
-- Era SpellEffect 400080 -> enchant 6708 -> ability 399969/399965.
-- Check the equipped rune, not whether its engraving recipe was learned.
return rune.itemEnchantmentID == 6708

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Reuse the gated rune-enchantment value

Number(rune.itemEnchantmentID) validates one field read, but this return expression indexes the foreign rune table again and compares that fresh value without an access check. If the second read is secret or becomes protected, the equality operation can error or taint execution; the outer event pcall only contains the error. Cache the field once, validate the cached value, and compare that same value.

AGENTS.md reference: AGENTS.md:L4-L4

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant