Repository navigation
Account for automatic poison coverage from equipped Deadly Brew - #7
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7308075899
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| end | ||
| -- Era SpellEffect 400080 -> enchant 6708 -> ability 399969/399965. | ||
| -- Check the equipped rune, not whether its engraving recipe was learned. | ||
| return rune.itemEnchantmentID == 6708 |
There was a problem hiding this comment.
Reuse the gated rune-enchantment value
Number(rune.itemEnchantmentID) validates one field read, but this return expression indexes the foreign rune table again and compares that fresh value without an access check. If the second read is secret or becomes protected, the equality operation can error or taint execution; the outer event pcall only contains the error. Cache the field once, validate the cached value, and compare that same value.
AGENTS.md reference: AGENTS.md:L4-L4
Useful? React with 👍 / 👎.
An equipped Deadly Brew rune provides automatic poison coverage on otherwise unpoisoned weapons. Read the equipped chest engraving through the documented Classic API and recognize enchant 6708, verified against the pinned Era spell/enchant records. Do not confuse knowing the engraving recipe with wearing the rune. Unknown rune observations stay quiet.
Add RUNE_UPDATED handling, a private regression and a dedicated SoD startup/transition smoke profile. Update 1.2.0 release documentation before its tag is published.
Validation: 141 tests in both orders under Lua 5.1/5.2; all seven NoPoizen client/ruleset smoke profiles on both; Lua parsing; four Python packaging/source checks; diff checks. Source and offline evidence only; no live SoD claim.