Repository navigation
Show a native icon in the AddOns list - #8
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f69c3f7b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## Interface-Titan: 38001, 38002 | ||
| ## Title: NoPoizen | ||
| ## Version: 1.2.0 | ||
| ## IconTexture: 132273 |
There was a problem hiding this comment.
Use a texture path for IconTexture
TOC metadata is returned as text, so the native AddOns list passes "132273" to SetTexture as a file path rather than the numeric file-data ID 132273; the texture therefore fails to resolve and the change does not reliably replace the question-mark icon. Specify the corresponding Blizzard texture path (for example, Interface\\Icons\\INV_Potion_19) or package an icon asset instead.
AGENTS.md reference: AGENTS.md:L5-L5
Useful? React with 👍 / 👎.
The AddOns list falls back to a question mark when icon metadata is absent. Declare Blizzard's poison texture through
IconTextureso the native list displays an appropriate icon. Bump the patch version and document the change.Validation: both test orders pass under Lua 5.1; TOC runtime paths, private-library vendor checks, and
git diff --checkpass. NoPoizen Retail/Forever smoke simulations also pass. Checked the metadata contract against installed Retail and Forever UI exports; live rendering remains unverified.