Skip to content

Show a native icon in the AddOns list - #8

Merged
AlexAllocated merged 1 commit into
mainfrom
codex/addon-list-icons
Sep 25, 2026
Merged

AlexAllocated merged 1 commit into
mainfrom
codex/addon-list-icons

Conversation

@AlexAllocated

Copy link
Copy Markdown
Owner

The AddOns list falls back to a question mark when icon metadata is absent. Declare Blizzard's poison texture through IconTexture so the native list displays an appropriate icon. Bump the patch version and document the change.

Validation: both test orders pass under Lua 5.1; TOC runtime paths, private-library vendor checks, and git diff --check pass. NoPoizen Retail/Forever smoke simulations also pass. Checked the metadata contract against installed Retail and Forever UI exports; live rendering remains unverified.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T02:31:40.613934Z 7f69c3f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AlexAllocated
AlexAllocated merged commit fe8c862 into main Sep 25, 2026
4 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f69c3f7b5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread NoPoizen.toc
## Interface-Titan: 38001, 38002
## Title: NoPoizen
## Version: 1.2.0
## IconTexture: 132273

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use a texture path for IconTexture

TOC metadata is returned as text, so the native AddOns list passes "132273" to SetTexture as a file path rather than the numeric file-data ID 132273; the texture therefore fails to resolve and the change does not reliably replace the question-mark icon. Specify the corresponding Blizzard texture path (for example, Interface\\Icons\\INV_Potion_19) or package an icon asset instead.

AGENTS.md reference: AGENTS.md:L5-L5

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant