Skip to content

Release PvPTogether 1.2.0 with current Classic client support - #6

Merged
AlexAllocated merged 1 commit into
mainfrom
codex/all-clients
Sep 25, 2026
Merged

AlexAllocated merged 1 commit into
mainfrom
codex/all-clients

Conversation

@AlexAllocated

Copy link
Copy Markdown
Owner

Advertise support for current Classic client families and verify the shared category-border/settings/cleanup path against their native nameplate contract. Native layout remains Blizzard-owned; no per-category styles return.

Clients: Retail, Forever, Era/Hardcore/SoD, Anniversary/TBC, Mists Classic and Titan Reforged. One codebase and private libchev 1.1.3 per addon.

Validation: 117 regressions in both orders on Lua 5.1/5.2, including six client profiles; parsing, TOC, StyLua and exact vendor checks.

Source-backed and offline validation only. Live rendering, gameplay, audio and engine-level taint validation remain separate; the user requested implementation without waiting to level a Forever rogue. Exact evidence and remaining checks are in CLIENT_COMPATIBILITY.md.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T02:05:10.044089Z 9a5a8f3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AlexAllocated
AlexAllocated merged commit 989661c into main Sep 25, 2026
4 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a5a8f3916

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/clients.lua
Comment on lines +17 to +21
e.GetBuildInfo = function()
return version, "fixture", "", 0
end
e.NamePlateSetupOptions, e.NamePlateConstants, e.NameplatesOverrides = nil, nil, nil
e.Settings.NAMEPLATE_OPTIONS_CATEGORY_ID = 37

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Model each client's API shape in compatibility tests

Each purported client profile inherits the same Retail-oriented fixture globals and changes only GetBuildInfo plus three explicitly removed legacy globals; GetBuildInfo is used only for diagnostics, so the border/settings path is identical in all six cases. If a supported Classic family differs in Settings, C_NamePlate, restriction APIs, constants, or frame shape, every profile will still pass, leaving the release's advertised cross-client compatibility check ineffective. Configure the actual capability/API shape for each family rather than varying only its version string.

AGENTS.md reference: AGENTS.md:L9-L9

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant