Repository navigation
Release PvPTogether 1.2.0 with current Classic client support - #6
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a5a8f3916
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| e.GetBuildInfo = function() | ||
| return version, "fixture", "", 0 | ||
| end | ||
| e.NamePlateSetupOptions, e.NamePlateConstants, e.NameplatesOverrides = nil, nil, nil | ||
| e.Settings.NAMEPLATE_OPTIONS_CATEGORY_ID = 37 |
There was a problem hiding this comment.
Model each client's API shape in compatibility tests
Each purported client profile inherits the same Retail-oriented fixture globals and changes only GetBuildInfo plus three explicitly removed legacy globals; GetBuildInfo is used only for diagnostics, so the border/settings path is identical in all six cases. If a supported Classic family differs in Settings, C_NamePlate, restriction APIs, constants, or frame shape, every profile will still pass, leaving the release's advertised cross-client compatibility check ineffective. Configure the actual capability/API shape for each family rather than varying only its version string.
AGENTS.md reference: AGENTS.md:L9-L9
Useful? React with 👍 / 👎.
Advertise support for current Classic client families and verify the shared category-border/settings/cleanup path against their native nameplate contract. Native layout remains Blizzard-owned; no per-category styles return.
Clients: Retail, Forever, Era/Hardcore/SoD, Anniversary/TBC, Mists Classic and Titan Reforged. One codebase and private libchev 1.1.3 per addon.
Validation: 117 regressions in both orders on Lua 5.1/5.2, including six client profiles; parsing, TOC, StyLua and exact vendor checks.
Source-backed and offline validation only. Live rendering, gameplay, audio and engine-level taint validation remain separate; the user requested implementation without waiting to level a Forever rogue. Exact evidence and remaining checks are in CLIENT_COMPATIBILITY.md.