feat(client): SharedWorker support in the event transport - #4
Merged
Merged
Conversation
`connect(url, { worker })` now accepts a SharedWorker (reached through its
`port`), a dedicated Worker or a raw MessagePort in addition to a
ServiceWorker — the page posts to `worker.port ?? worker`, and every client
still gets its own MessageChannel.
`WrpcClientProxy` listens on both `self` `message` (Service Worker/dedicated
Worker) and the SharedWorker `connect` event, treating each page's connection
port as the same control bus `self` is in a Service Worker. It also takes a
`url` option — the server it connects to — instead of always deriving one
from `self.location`, and releases a page's port (and its pending answers)
when that port closes.
Also fixes ClientEventTransport.close() being callable only once: a second
close(), or terminate() after close(), threw a TypeError that masked the
real error from a failed open().
Docs, types, CHANGELOG and the browser bundle budget (15 -> 16 KB; SSE entry
16 -> 17 KB) updated accordingly.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connect(url, { worker })now accepts a SharedWorker (reached through itsport), a dedicated Worker or a raw MessagePort in addition to a ServiceWorker — the page posts toworker.port ?? worker, and every client still gets its own MessageChannel.WrpcClientProxylistens on bothselfmessage(Service Worker/dedicated Worker) and the SharedWorkerconnectevent, treating each page's connection port as the same control busselfis in a Service Worker. It also takes aurloption — the server it connects to — instead of always deriving one fromself.location, and releases a page's port (and its pending answers) when that port closes.Also fixes ClientEventTransport.close() being callable only once: a second close(), or terminate() after close(), threw a TypeError that masked the real error from a failed open().
Docs, types, CHANGELOG and the browser bundle budget (15 -> 16 KB; SSE entry 16 -> 17 KB) updated accordingly.