Repository navigation
UI 重新设计：P0 打磨 + P1 单一活动栏 + P2 引用查找/发布预览 - #41
Open
AliceJumpGrokBot wants to merge 29 commits into
Open
AliceJumpGrokBot wants to merge 29 commits into
AliceJumpGrokBot wants to merge 29 commits into
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 119 files, which is 19 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (119)
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Tune shared tokens and controls toward more whitespace and fewer gray border boxes: lighter --bg-row, softer --border, slightly larger spacing scale, lighter secondary/mini/icon buttons, and cards that rely more on background than heavy outlines. Accent stays on primary actions and status. Panel CSS polished to match; design-system spacing hard rules updated.
The standalone box panel/gallery (media/boxPanel) was folded into the unified annotation editor long ago, but leftovers stayed behind: openBoxEditor() had no caller, view.boxAssets/boxGallery nls keys and the boxAssetsTitle webview key had no consumer, and the design-system audit still registered a media/boxPanel host that no longer exists. Keep the position-preview helpers used by hover/completion and move them to src/positionPreview.ts so the file name says what it does.
- Console / Resource Preview / Annotation Management / Annotation Editor used consistently across package.json, host bundles and webviews (6 langs) - contributes.configuration split into 5 titled categories - tests flatten the configuration array
… they say - openAnnotationEditor accepts an image Uri or shows a QuickPick of images in Annotation Management, then opens the annotation editor - openResourcePublisher (now titled "Publish Resources…") runs the Template/Rect/Point publish flow instead of only opening the panel
…ar, badges - console.* commands (run task, start/pause/resume/stop, stop current task, show logs, refresh, connect/disconnect game) sharing the webview logic - menus: view/title actions per view, commandPalette when clauses driven by okScriptToolkit.projectReady / executorRunning / executorPaused / taskRunning - status bar item mirroring executor state; console badge for running+queued tasks; temp screenshot badge for unsorted shots - okScriptToolkit.hasCharacterData context key hides the character & skill manager in the palette, console title menu and Game segment when no data - isSupportedProject moved to projectConfig for reuse
- vendor @vscode/codicons 0.0.36 (css+ttf, licenses) into media/shared/codicons - shared/icons.js (OkIcons.icon/label/iconOnly) loaded by every panel; CSP gains font-src; applySharedAssets fills the two new placeholders - console, resource preview, annotation management, temp shots, annotation editor and character manager use codicons; icon-only buttons get aria-label - distinct icons: sync default (sync) vs restore (discard) vs swap (arrow-swap) - design-system doc + audit step 7 enforce codicons and forbid glyph icons - jsdom tests inline shared/icons.js like thumbnailActions.js
- side nav gets codicons + tooltips; collapses to a 44px icon rail at <=640px and to a top segmented bar at <=480px (labels only <=340px) - arrow keys move between segments (tablist pattern) - status bar rows and card actions wrap instead of overflowing - denser task cards (smaller header padding/title, 2-line description) - snapshot buttons are neutral secondary buttons, not primary
- Annotation Management empty state explains what goes here and offers Screenshot / Import (no longer reuses Resource Preview's COCO hint) - invalid annotation source shows a persistent banner with Open source file - Resource Preview empty state lists the COCO paths actually checked and links to Annotation Management; Box/Point modes get their own hint - Console status banner renders icon + action buttons (Set Project Path, Set Python Path, Show Logs, Retry, Reload Tasks, Stop Executor); executor start/exit errors go inline, falling back to a notification with the same buttons only when the Console is hidden - shared .panel-empty__*/.panel-actions/.panel-banner styles; unused noTemplatesWithHint/noTemplateAssets* strings removed
The swap was already behind a modal confirm; after it is written the notification now offers Undo, which restores both images' original boxes only if neither image changed since the swap.
…ete apart - single click selects (no more 500ms delayed insert vs double-click copy); double-click / Enter = primary action (Resource Preview: insert reference, Annotation Management: open annotation editor, Temp Shots: preview) - keyboard: roving tabindex, role=listbox/option, arrows/Home/End move, E = annotate, Ctrl/Cmd+C = copy reference, Delete = delete (host confirms) - delete moved out of the view/swap row into its own top-right slot with danger styling on hover/focus; selected/focus card states - hints and card tooltips describe the gestures (6 languages) - tests updated for the new gestures; keyboard navigation covered
… segment It is project data, not part of the game connection; the entry stays hidden unless okScriptToolkit.hasCharacterData is true.
Canonical names, new commands, status bar, inline errors, gestures, swap undo, settings categories; parity audit flags the gesture change as pending on the JetBrains side.
…ebars - .gbar is a grid: give its rows min-width:0 so long game/executor text no longer widens the bar past the viewport (overflowed at ~700px). - ≤640: status-bar action group may shrink and wrap (was flex:0 0 auto, so '关闭执行器' was cut off at 260px). - Task cards: the primary action (启动 / 启用) never shrinks; the 参数 button is the one that gives way. ≤340: the title may wrap instead of collapsing to an ellipsis. Checked at 700/640/560/480/400/340/300/260 with no horizontal overflow.
…onsolePanel Pure move for the P1 TreeView/params split. consolePanel re-exports the same helpers so toolboxConnect and extension keep working.
…references) MarkdownString.isTrusted uses an enabledCommands allowlist with only the two extension commands; link targets are encoded so names cannot close the markdown link. Snapshot test in scripts/test_hover_links.js.
… explorer menu - okScriptToolkit.findTemplateReferences: fL.xxx / self.pos.xxx / "key" in workspace Python files → QuickPick → jump (pure finder + test) - revealResource now filters the Resources view to the name - Explorer '用标注编辑器打开' only on .png/.jpg/.jpeg/.webp
After every publish decision is collected and before anything is written, a QuickPick lists the files that will be written and the template set change (new / overwrite / removed), compared by name only since saveToAssets re-packs bboxes. Esc writes nothing; saveToAssets and position publish semantics are unchanged.
… by name only P1 keyed draft cards by image file name, so they never matched the published fL.<name> entries, and compared bboxes across coordinate systems (publish re-packs crops), flagging everything as modified.
@vscode/test-electron is not a dependency and needs a display, so no real Extension Host or screenshot regression; documented in docs/testing.md.
…AliceJump#42 Rebase ui/redesign-p0-p2 onto main (includes AliceJump#42). Keep one capture flow: VS Code keybinding and Windows RegisterHotKey both land in the AliceJump#41 Resources inbox (lossless BMP), not the old templates-only path. Keep AliceJump#42 prewarm, GlobalScreenshotHotkey, and local review-time scripts. Update docs/keymap notes and background-screenshot tests accordingly.
AliceJumpGrokBot
force-pushed
the
ui/redesign-p0-p2
branch
from
October 12, 2026 07:31
fb3ed3b to
4bee3d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
冲突处理（相对 main / #42）
main（含 feat: prewarm screenshots, add global capture and local review times #42d950b21：截图预热、系统级热键、本机时区 review 时间）。RegisterHotKey全局热键均写入 资源收件箱（UI 重新设计：P0 打磨 + P1 单一活动栏 + P2 引用查找/发布预览 #41 inbox / 无损 BMP），不再以旧的screenshotToTemplate模板目录为唯一终点。GlobalScreenshotHotkey、本地时区 review 脚本；收件箱语义采用 UI 重新设计：P0 打磨 + P1 单一活动栏 + P2 引用查找/发布预览 #41。screenshotToTemplate命令仍保留（无默认键位），可显式打开标注管理并截图。简洁工具风格（clean tokens）
P0 打磨
openAnnotationEditor/openResourcePublisherP1 信息架构
P2 打磨
未做 / 降级
验证
tsc通过；npm test通过（含test:background-screenshot/test:global-hotkey/test:command-contract）文档
docs/design-system.md、docs/interaction-parity-audit.md、docs/feature-parity.md（含英文版）。docs/project-config/docs/box-resources已按「Ctrl+Alt+S → 收件箱」对齐。