Skip to content

[DPG] Update deuteron analysis - #17172

Merged
njacazio merged 2 commits into
AliceO2Group:masterfrom
rliotino99:update_deuteron_analysis
Jul 22, 2026
Merged

[DPG] Update deuteron analysis#17172
njacazio merged 2 commits into
AliceO2Group:masterfrom
rliotino99:update_deuteron_analysis

Conversation

@rliotino99

Copy link
Copy Markdown
Contributor

Changes in table hmpid, table producer and deuteron analysis task

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 4 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Update deuteron analysis [DPG] Update deuteron analysis Jul 22, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 1f92653 at 2026-07-22 19:12:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 23 errors and 41 warnings.'
Found 23 errors and 41 warnings.
++ [[ 23 -gt 0 ]]
++ cat /sw/BUILD/3494a3910fa5f8e8ec9f1b0f61011e6e7e2f71f4/O2Physics-code-check/errors.txt
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:19:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:28:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:84:13: error: member 'rich0' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:84:24: error: member 'rich1' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:84:35: error: member 'rich2' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:84:46: error: member 'rich3' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:84:57: error: member 'rich4' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:84:68: error: member 'rich5' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:84:79: error: member 'rich6' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:86:15: error: member 'nmean' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:88:13: error: no header providing "o2::framework::InitContext" is directly included [misc-include-cleaner,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:92:5: error: no header providing "o2::framework::AxisSpec" is directly included [misc-include-cleaner,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:103:64: error: no header providing "o2::framework::HistType" is directly included [misc-include-cleaner,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:152:56: error: no header providing "o2::framework::kTH2F" is directly included [misc-include-cleaner,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:155:36: error: no header providing "o2::framework::kTH1F" is directly included [misc-include-cleaner,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:191:16: error: no header providing "std::abs" is directly included [misc-include-cleaner,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:204:29: error: no header providing "std::hypot" is directly included [misc-include-cleaner,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:207:14: error: no header providing "std::pow" is directly included [misc-include-cleaner,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:207:40: error: no header providing "std::cos" is directly included [misc-include-cleaner,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:210:27: error: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidTableProducer.cxx:119:16: error: member 'mAbsCosT' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidTableProducer.cxx:119:57: error: no header providing "TMath::DegToRad" is directly included [misc-include-cleaner,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidTableProducer.cxx:120:16: error: member 'mAbsSinT' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
++ [[ 41 -gt 0 ]]
++ cat /sw/BUILD/3494a3910fa5f8e8ec9f1b0f61011e6e7e2f71f4/O2Physics-code-check/warnings.txt
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:181:50: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:183:49: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:185:59: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:187:40: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:189:40: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:191:46: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:193:44: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:221:31: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:259:17: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:261:17: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:285:46: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:291:17: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:294:17: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:304:46: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:335:19: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:337:19: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:341:19: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@njacazio
njacazio enabled auto-merge (squash) July 22, 2026 17:19
@njacazio
njacazio merged commit 18388ef into AliceO2Group:master Jul 22, 2026
14 of 15 checks passed
@vkucera

vkucera commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

@rliotino99 How did you come up with the include changes?
@njacazio Why did you approve the PR despite the include errors?

@rliotino99

Copy link
Copy Markdown
Contributor Author

Hello @vkucera, regarding the include changes, as far as I can remember, I used VS Code IntelliSense to trace the unresolved symbols to the headers where they are defined. Based on that, I added the corresponding #includes rather than relying on trial and error.

I also remember noticing that, across different commits, some of the code-check errors disappeared automatically. I observed the same behavior recently in another pull request, where those particular errors no longer appeared.

@vkucera

vkucera commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

@rliotino99 But how did that make you remove the Framework headers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants