Skip to content

[PWGLF] Fix H3L decay point + fix git index for case insensitive fs - #17229

Closed
mpuccio wants to merge 3 commits into
AliceO2Group:masterfrom
mpuccio:genericHe3body
Closed

[PWGLF] Fix H3L decay point + fix git index for case insensitive fs#17229
mpuccio wants to merge 3 commits into
AliceO2Group:masterfrom
mpuccio:genericHe3body

Conversation

@mpuccio

@mpuccio mpuccio commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

mpuccio and others added 3 commits July 27, 2026 16:13
The rename to nucleitpcPbPb.cxx in d5e065d (AliceO2Group#17177) was done from a
case-insensitive filesystem, so the old lowercase path never got
removed from the tree. Both paths collide into one file on
case-insensitive filesystems (macOS/Windows), making the tracked file
unrestorable via reset/checkout since git pathspec matching is
case-insensitive here.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions github-actions Bot changed the title Fix H3L decay point + fix git index for case insensitive fs [PWGLF] Fix H3L decay point + fix git index for case insensitive fs Jul 28, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 25 errors, ⚠️ 8 warnings, 🔕 0 disabled

@mpuccio
mpuccio enabled auto-merge (squash) July 28, 2026 09:55

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mpuccio.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 94778c0 at 2026-07-28 13:31:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 81 errors and 24 warnings.'
Found 81 errors and 24 warnings.
++ [[ 81 -gt 0 ]]
++ cat /sw/BUILD/d8e07cf26c3c38a6f852e2f14aab9dd4ca7b2bdf/O2Physics-code-check/errors.txt
PWGLF/DataModel/Vtx3BodyTables.h:112:42: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/DataModel/Vtx3BodyTables.h:113:38: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/DataModel/Vtx3BodyTables.h:114:46: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/DataModel/Vtx3BodyTables.h:115:42: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:81:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:82:39: error: 'betheBlochParNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:83:39: error: 'particleName' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:84:22: error: variable 'hEvents' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:85:22: error: variable 'hEventsZorro' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:86:22: error: variable 'hZvtx' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:87:22: error: variable 'hCentFT0A' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:88:22: error: variable 'hCentFT0C' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:89:22: error: variable 'hCentFT0M' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:90:22: error: variable 'hNsigma3HeSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:91:22: error: variable 'hDeDx3HeSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:92:22: error: variable 'hDeDxTot' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:93:22: error: variable 'hH3LMassBefSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:94:22: error: variable 'hH3LMassTracked' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:95:22: error: variable 'hH4LMassBefSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:96:22: error: variable 'hH4LMassTracked' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:97:22: error: variable 'hDecayChannel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:98:22: error: variable 'hIsMatterGen' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:99:22: error: variable 'hIsMatterGenTwoBody' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:100:22: error: variable 'hEvtMC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:101:22: error: variable 'hImpactParamGen' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:102:22: error: variable 'hImpactParamGenOneReco' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:103:22: error: variable 'hImpactParamReco' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:104:22: error: variable 'hGen3HLBeforeEvtSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:105:22: error: variable 'hGen3HLAfterSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:106:22: error: variable 'hGenOneRecoCentrality' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:107:22: error: variable 'hRecoCentrality' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:108:22: error: variable 'hGenEventsNchEta05' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:109:22: error: variable 'hGenEventsNchEta08' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:110:22: error: variable 'hGenCentralityColvsMultiplicityGenEta05' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:111:22: error: variable 'hGenCentralityColvsMultiplicityGenEta08' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:112:22: error: variable 'hGenCentralityColvsImpactParamGen' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:113:22: error: variable 'hGenCentralityColvsFT0Cmultiplicity' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:114:22: error: variable 'hRecoCentralityColvsMultiplicityRecoEta05' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:115:22: error: variable 'hRecoCentralityColvsMultiplicityRecoEta08' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:116:22: error: variable 'hRecoCentralityColvsImpactParamReco' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:117:22: error: variable 'hRecoCentralityColvsFT0Cmultiplicity' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:118:22: error: variable 'hGen3HLvsImpactParameterBeforeEvtSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@mpuccio
mpuccio disabled auto-merge July 28, 2026 11:58
@mpuccio mpuccio closed this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants