Skip to content

[PWGUD] add zdc time cut - #17259

Open
miedema-11 wants to merge 2 commits into
AliceO2Group:masterfrom
miedema-11:master
Open

[PWGUD] add zdc time cut#17259
miedema-11 wants to merge 2 commits into
AliceO2Group:masterfrom
miedema-11:master

Conversation

@miedema-11

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 2 disabled

@github-actions github-actions Bot changed the title add zdc time cut [PWGUD] add zdc time cut Jul 30, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for a2d31fa at 2026-07-30 05:59:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 46 errors and 46 warnings.'
Found 46 errors and 46 warnings.
++ [[ 46 -gt 0 ]]
++ cat /sw/BUILD/7e33f4ed4783eac3cdcabc16b68461d7202fa81f/O2Physics-code-check/errors.txt
PWGUD/Tasks/flowCorrelationsUpc.cxx:43:1: error: included header TString.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/flowCorrelationsUpc.cxx:60:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGUD/Tasks/flowCorrelationsUpc.cxx:62:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGUD/Tasks/flowCorrelationsUpc.cxx:122:48: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGUD/Tasks/flowCorrelationsUpc.cxx:326:29: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGUD/Tasks/flowCorrelationsUpc.cxx:363:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGUD/Tasks/flowCorrelationsUpc.cxx:374:40: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGUD/Tasks/flowCorrelationsUpc.cxx:402:29: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGUD/Tasks/flowCorrelationsUpc.cxx:402:48: error: the parameter 'tracks' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGUD/Tasks/flowCorrelationsUpc.cxx:427:33: error: the parameter 'tracks1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGUD/Tasks/flowCorrelationsUpc.cxx:427:50: error: the parameter 'tracks2' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGUD/Tasks/flowCorrelationsUpc.cxx:443:24: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGUD/Tasks/flowCorrelationsUpc.cxx:497:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:67:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:69:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:245:22: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:256:5: error: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:501:59: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:501:92: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:504:59: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:504:92: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:521:12: error: variable 'dnx' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:521:17: error: variable 'val' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:543:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:548:12: error: variable 'dnx' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:548:17: error: variable 'val' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:570:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:578:40: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:586:40: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:632:29: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:783:22: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:789:26: error: implicit conversion 'unwrap_t<int>' (aka 'int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:793:20: error: implicit conversion 'unwrap_t<int>' (aka 'int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:797:24: error: implicit conversion 'unwrap_t<int>' (aka 'int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:801:20: error: implicit conversion 'unwrap_t<int>' (aka 'int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:816:34: error: use designated initializer list to initialize 'AcceptedTracks' [modernize-use-designated-initializers,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:847:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:887:9: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:888:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:889:14: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:889:38: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:891:18: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@amatyja

amatyja commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Hi @miedema-11,
Your code is fine. However, change your nick to be more suitable to your person (name and surname).
Best regards
Adam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants