Conversation
Iir0R
requested review from
CapoMK25,
MikhailDeriabin and
hoan301298
as code owners
July 27, 2026 14:18
…nd-data-structure-to-match-that-of-what-is-needed-on-the-clientside
CapoMK25
approved these changes
Jul 27, 2026
Iir0R
marked this pull request as draft
July 30, 2026 05:46
Iir0R
marked this pull request as ready for review
August 1, 2026 14:34
…nd-data-structure-to-match-that-of-what-is-needed-on-the-clientside
Collaborator
|
Looks good and hard work. I will take closer look by Monday at the latest, if PR isn't merged before that. |
CapoMK25
deleted the
790-feature-request-update-the-soulhome-api-and-data-structure-to-match-that-of-what-is-needed-on-the-clientside
branch
August 1, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description
Updated code to meet requirements of Issue.
Change list
NOTE: Furniture location isn't validated yet as not all items have sizes.
NOTE: Currently, room Put can't accept array, only single object. Authorize can't get id from array, will be changed in separate update.
Work on this task was started some time ago, so I'm not sure how it will behave with new changes. Creating a PR to see it'll work.