Skip to content

790 feature request update the soulhome api and data structure to match that of what is needed on the clientside - #887

Merged
CapoMK25 merged 14 commits into
devfrom
790-feature-request-update-the-soulhome-api-and-data-structure-to-match-that-of-what-is-needed-on-the-clientside
Aug 1, 2026
Merged

790 feature request update the soulhome api and data structure to match that of what is needed on the clientside#887
CapoMK25 merged 14 commits into
devfrom
790-feature-request-update-the-soulhome-api-and-data-structure-to-match-that-of-what-is-needed-on-the-clientside

Conversation

@Iir0R

@Iir0R Iir0R commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Brief description

Updated code to meet requirements of Issue.

Change list

  • Updated soulHome to include rooms and furniture
  • Updating room data and furniture implemented
  • Updated Items to have rotation, position, placedOn_id, placedOnLocation
  • Rooms updated with roomColour, wallpaper, floor
  • SoulHome Room creation, activation and deactivation implemented
  • Timed inactive Room removal implemented and sending furniture to Stock
  • Added furnitureTotalValue to Clan

NOTE: Furniture location isn't validated yet as not all items have sizes.
NOTE: Currently, room Put can't accept array, only single object. Authorize can't get id from array, will be changed in separate update.

Work on this task was started some time ago, so I'm not sure how it will behave with new changes. Creating a PR to see it'll work.

…nd-data-structure-to-match-that-of-what-is-needed-on-the-clientside

@CapoMK25 CapoMK25 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid, approved.

Comment thread src/clanInventory/room/dto/room.dto.ts Outdated
Comment thread src/clanInventory/room/dto/updateRoom.dto.ts Outdated
Comment thread src/clan/utils/defaultValues/items.ts Outdated
Comment thread src/clan/utils/defaultValues/items.ts Outdated
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Altzone-Server Jul 27, 2026
@Iir0R
Iir0R marked this pull request as draft July 30, 2026 05:46
@codecov-alt

codecov-alt Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.26966% with 56 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/clan/clan.service.ts 67.34% 16 Missing ⚠️
src/clanInventory/soulhome/soulhome.service.ts 13.33% 13 Missing ⚠️
src/clanInventory/room/room.service.ts 89.65% 9 Missing ⚠️
src/common/service/basicService/BasicService.ts 64.00% 9 Missing ⚠️
src/clan/join/join.service.ts 92.39% 7 Missing ⚠️
src/clanInventory/room/room.scheduler.ts 96.66% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/clan/utils/clanHelper.service.ts 95.74% <100.00%> (-0.34%) ⬇️
src/clan/utils/defaultValues/items.ts 100.00% <100.00%> (ø)
src/clanInventory/item/const/itemProperties.ts 100.00% <ø> (ø)
src/clanInventory/item/item.service.ts 94.44% <100.00%> (ø)
src/clanInventory/item/itemHelper.service.ts 86.48% <100.00%> (+0.37%) ⬆️
src/clanInventory/room/const/roomConst.ts 100.00% <100.00%> (ø)
src/clanInventory/room/roomRemoval.notifier.ts 100.00% <100.00%> (ø)
src/clanShop/clanShop.service.ts 83.50% <100.00%> (+0.34%) ⬆️
src/fleaMarket/fleaMarket.service.ts 79.01% <100.00%> (+0.06%) ⬆️
src/fleaMarket/fleaMarketHelper.service.ts 100.00% <100.00%> (ø)
... and 6 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Iir0R
Iir0R marked this pull request as ready for review August 1, 2026 14:34
…nd-data-structure-to-match-that-of-what-is-needed-on-the-clientside
@tickBit

tickBit commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Looks good and hard work. I will take closer look by Monday at the latest, if PR isn't merged before that.
Patch coverage is really high 👍

@CapoMK25 CapoMK25 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, approved.

@CapoMK25
CapoMK25 merged commit 0dbdd9d into dev Aug 1, 2026
5 checks passed
@CapoMK25
CapoMK25 deleted the 790-feature-request-update-the-soulhome-api-and-data-structure-to-match-that-of-what-is-needed-on-the-clientside branch August 1, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Feature request: Update the SoulHome API and data-structure to match that of what is needed on the clientside.

4 participants