Repository navigation
Evaluate trimming and Native AOT with native compatibility experiments - #62
Merged
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unrestricted trimming and Native AOT make spn much smaller (~18/~14 MB locally) but break normal command initialization; a successful bare version probe misses this failure. Add an isolated six-mode publishing investigation that records build diagnostics, probes full CLI/JSON/docs/licenses, runs the existing lifecycle/provider/native-vault smoke and measures functioning candidates.
The promising local candidate is partial trimming + ReadyToRun: 39.46 MB executable / 16.98 MB gzip, warm Home ~76 ms versus ~188 ms in the prior untrimmed reference. All seven local smoke suites pass, including install/PATH, updater rollback and OpenCode. Plain partial trimming is smaller (23.13 MB) but slower (~399 ms Home). Clean strict analysis still rejects current reflection-based JSON; Spectre command metadata is also incompatible with unrestricted trimming/AOT.
Document raw evidence and a measured go/no-go, add native Windows/Linux/macOS research CI with isolated credential vaults and report-only uploads. Keep supported release publishing and warning policy intact. Follow-ups #60 (typed/source-generated JSON) and #61 (CLI metadata/AOT) are linked in the prioritized backlog.
Validation: local baseline and expected failure cases exercise the new runner; 138 .NET tests, ten tooling tests, documentation/whitespace checks pass. Native investigation and normal Windows/Linux/macOS CI, Quality and Security pass. Windows full → partial-R2R: 76.71 → 36.89 MB, warm state preview 199.87 → 116.38 ms; native credential/install/update/provider smoke passes for this diagnostic candidate on all three platforms. Strict compatibility diagnostics remain, so promotion is blocked by #60/#61. Part of #26; retain the umbrella for the compatibility fixes and remaining acceptance.