fix(cli): honor declared package manager versions - #95
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a01746-0839-7728-b8f0-cd5d2326b139 Co-authored-by: Upd4ting <upd4ting@gmail.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a01746-0839-7728-b8f0-cd5d2326b139 Co-authored-by: Upd4ting <upd4ting@gmail.com>
Upd4ting
force-pushed
the
fix/reproducible-package-manager
branch
from
August 20, 2026 09:08
ffcc859 to
572979a
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packageManagerdeclaration instead of dropping its versionRebase status
Rebased onto
origin/mainatb507915de42ae37bea694c99078fefdbf302d6c9(runtime PRs #97, #98, #100, and #101). Current head:572979ade79142df9fc8c18da82d78eaaf17ce29.git range-diffreports both PR commits patch-identical across the rebase. The incremental PR diff contains only:src/core/cli/package-manager.tssrc/core/cli/commands/module/init.tsThe rebased frozen install resolved published
@antelopejs/interface-core@0.0.11from the new base.Deterministic-success matrix
Environment: Node 20.9.0, Corepack 0.20.0, globally installed pnpm 11.22.0. Timings are single-run sanity measurements.
pnpm installnode:sqlite)corepack pnpm@10.6.5 install --frozen-lockfilecorepack npm@10.2.4 ci --prefer-offlineEUSAGE) in 408 ms; lock unchangedcorepack npm@10.2.4 install --prefer-offlinecorepack pnpm@10.6.5 install --ignore-workspace --frozen-lockfile --prefer-offlineERR_PNPM_OUTDATED_LOCKFILE) in 417 ms; lock unchangedcorepack pnpm@10.6.5 install --ignore-workspace --prefer-offlineCall-site contract
There are two production call sites for
getInstallCommand:updateAll three official module templates currently contain a
pnpm-lock.yaml, so initialization must be able to refresh copied locks. Package downloads remain strict.Command/compatibility matrix
pnpm@10.6.5yarn@1.22.21npm@10.2.4Validation on rebased head
@antelopejs/interface-coreresolved to 0.0.11pnpm build: passedpnpm test: passed with pinned pnpm shimpnpm test:coverage: passed — 94.56% statements/lines, 92.28% branches, 91.98% functionspnpm lint: passed with 2 pre-existing warnings and 1 pre-existing informational diagnosticEnvironment limitation
This orb's global pnpm 11.22.0 requires a newer Node version than Node 20.9.0. Repository scripts contain nested bare
pnpmcalls, and the #101 package-consumer fixture intentionally has nopackageManager; without a pinned shim those nested calls select pnpm 11 and fail before exercising repository code. Validation therefore prepended a temporarypnpmwrapper that delegates tocorepack pnpm@10.6.5. No wrapper or environment-specific change is committed.The earlier Greptile P1 was addressed in the second commit; its review thread remains resolved. This PR must not be merged as part of this update.