fix(deps): support Core 1.5 canonical interfaces - #17
Merged
Conversation
Allow Core and API to select canonical interface versions from the existing minima through the pre-1.0 contract. Refresh the lockfile to interface-core and interface-api 0.0.11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before / after
mainpins@antelopejs/interface-coreto^0.0.6and@antelopejs/interface-apito^0.0.8. Those0.0.xcaret ranges reject the canonical 0.0.11 packages selected by the future Core 1.5 stack. The currently published auth-jwt 1.0.1 manifest is narrower still (^0.0.5for both packages).@antelopejs/interface-core:>=0.0.6 <1.0.0@antelopejs/interface-api:>=0.0.8 <1.0.0No auth implementation or hot-path code changes.
Proven contract
ImplementInterfaceat runtime anddefineConfigin test/playground configuration. The existing implementation shape{ internal: { Verify, Sign } }is accepted by the real 0.0.11ImplementInterface; no API #36-style wiring change is needed.new HTTPResult(status, body). The constructor contract is unchanged from interface-api 0.0.8 through 0.0.11.SignRaw/ValidateRaw, then rejected an altered token.Compatibility matrix
@antelopejs/core@1.4.7@antelopejs/api@1.2.3, interface-api 0.0.116712035fb9ecbb924b5916788d9bc50123f77a8atarball@antelopejs/api@1.2.3, interface-api 0.0.11Core-main tarball SHA-256:
43ef73097faa9ddd8e8ede0934463d54b9acbd1c2b2ca6862bc64a34a88f0daa.Validation
pnpm install --frozen-lockfilepnpm run buildpnpm run lintpnpm run test— 4 passingImplementInterfaceJWT create/validate/reject harness on interface-core 0.0.11pnpm packplus tar entry and packed-manifest inspection — 15 expected filespnpm publish --dry-run --no-git-checks— completed as a dry run; nothing published6086c270d08b75c349c8ba0cb973b4719ac4660468f0d654baa5103469b200c8Fixtures and limits
127.0.0.1ports 55147/55148 and was stopped cleanly after the assertions. No external service, database, or persistent data was used.interface-coreroot export but the API calls named proxies from the/runtimesubpath. WithstrictPort: trueon a free production port, startup and endpoint registration fallback complete with 0[ERROR]logs and the JWT flow passes. This is outside auth-jwt and is not changed here.Release order
Merge this PR, publish the auth-jwt patch, then cut the Core 1.5 RC so consumers can resolve the compatible auth-jwt manifest first.
Greptile Summary
This PR broadens the supported pre-1.0 ranges for the Core and API interface packages so auth-jwt can resolve the canonical Core 1.5 interfaces.
Confidence Score: 5/5
The PR appears safe to merge, with the manifests and lockfile consistently updated for the intended interface compatibility.
The changed dependency ranges preserve the existing minimum versions, the lockfile resolves a consistent 0.0.11 interface graph, and no concrete build, runtime, or security failure remains.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(deps): support canonical interface p..." | Re-trigger Greptile