In the updated content of the manual 在手册更新内容 - #4776
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
A few documented navigation/formatting and correctness issues were found (missing tool category in guide book pages, Moon title encoding, and X/Y vs X/Z coordinate wording).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the in-game manual content (Chinese and English) to reflect recent gameplay/mechanics changes, improve cross-references, and add missing documentation for the Moon feature.
Changes:
- Refreshed Guide Book acquisition/usage docs and linked monolith-related entries via
itemsfrontmatter. - Expanded/updated container (crate/shulker container/storage station) and other block/material documentation details.
- Added new “Moon” feature pages in both
zh_cnanden_us.
Verification:
- Not run (documentation-only changes).
File summaries
| File | Description |
|---|---|
| src/main/resources/assets/anvilcraft/ageratum/zh_cn/005_tool/000_guide_book.md | Updates Guide Book page content and frontmatter items. |
| src/main/resources/assets/anvilcraft/ageratum/zh_cn/004_block/402_mega_structure.md | Tweaks Dyson Sphere amplification description. |
| src/main/resources/assets/anvilcraft/ageratum/zh_cn/004_block/401_celestial_forging_anvil.md | Clarifies gravity behavior (sneaking exception). |
| src/main/resources/assets/anvilcraft/ageratum/zh_cn/004_block/331_hyperdimension_storage_station.md | Clarifies crafting prerequisite (requires 4 upgrades). |
| src/main/resources/assets/anvilcraft/ageratum/zh_cn/004_block/215_large_crate.md | Adds tips and updates storage/terminal behavior descriptions. |
| src/main/resources/assets/anvilcraft/ageratum/zh_cn/004_block/003_crate.md | Adds classification and crafting-window sections. |
| src/main/resources/assets/anvilcraft/ageratum/zh_cn/004_block/002_jewelcrafting_table.md | Refines replication description and recipe layout text. |
| src/main/resources/assets/anvilcraft/ageratum/zh_cn/004_block/001_redstone.md | Improves GUI description wording. |
| src/main/resources/assets/anvilcraft/ageratum/zh_cn/002_material/210_liquid_enchantment.md | Re-formats table and adds curse-related recipes. |
| src/main/resources/assets/anvilcraft/ageratum/zh_cn/002_material/140_void_matter.md | Adds crate-adjacent behavior note. |
| src/main/resources/assets/anvilcraft/ageratum/zh_cn/001_feature/301_moon.md | Adds new Moon feature page. |
| src/main/resources/assets/anvilcraft/ageratum/zh_cn/000_process/007.md | Reorders/clarifies tips about cursed-gold production sources. |
| src/main/resources/assets/anvilcraft/ageratum/en_us/005_tool/000_guide_book.md | Updates Guide Book page content and frontmatter items. |
| src/main/resources/assets/anvilcraft/ageratum/en_us/004_block/402_mega_structure.md | Tweaks Dyson Sphere amplification description. |
| src/main/resources/assets/anvilcraft/ageratum/en_us/004_block/401_celestial_forging_anvil.md | Clarifies gravity behavior (sneaking exception). |
| src/main/resources/assets/anvilcraft/ageratum/en_us/004_block/331_hyperdimension_storage_station.md | Clarifies crafting prerequisite (requires 4 upgrades). |
| src/main/resources/assets/anvilcraft/ageratum/en_us/004_block/215_large_crate.md | Adds tips and updates storage/terminal behavior descriptions. |
| src/main/resources/assets/anvilcraft/ageratum/en_us/004_block/003_crate.md | Adds classification and crafting-window sections. |
| src/main/resources/assets/anvilcraft/ageratum/en_us/004_block/002_jewelcrafting_table.md | Refines replication description and recipe layout text. |
| src/main/resources/assets/anvilcraft/ageratum/en_us/004_block/001_redstone.md | Improves GUI description wording. |
| src/main/resources/assets/anvilcraft/ageratum/en_us/002_material/210_liquid_enchantment.md | Adds curse-related recipes to liquid enchantment table. |
| src/main/resources/assets/anvilcraft/ageratum/en_us/002_material/140_void_matter.md | Adds crate-adjacent behavior note. |
| src/main/resources/assets/anvilcraft/ageratum/en_us/001_feature/301_moon.md | Adds new Moon feature page. |
| src/main/resources/assets/anvilcraft/ageratum/en_us/000_process/007.md | Clarifies tip about which replicated items carry vanishing curse. |
Review details
Suppressed comments (1)
src/main/resources/assets/anvilcraft/ageratum/en_us/001_feature/301_moon.md:24
- Minecraft uses X/Z for horizontal coordinates; using “X and Y coordinates” would imply a vertical (Y) check, which doesn’t match the concept of near/far side biomes. This should likely be X/Z instead of X/Y.
Biomes where the X and Y coordinates are both less than 1024 and greater than -1024 are on the near side of the Moon; all other areas are on the far side
- Files reviewed: 24/24 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Reason: Security scan — [MEDIUM] Variation selector characters detected: Content contains Unicode variation selectors (VS1-256). These are commonly used in emoji sequences but may indicate steganographic encoding or obfuscation Reply |
代码审查摘要 — PR #4776操作: review_requested 🟢 已逐条对照源码交叉验证通过
另外确认无副作用项:3×3×3 板条箱全并成一行(页面中最多 11 个 recipe 的先例)、 🔴 关键1. 新增「月面」段落的判据与代码不符(中英两侧同错)
|
| 文件(en/zh 对称) | 状态 | 说明 |
|---|---|---|
000_process/007.md |
✅ | 两 tip 已对齐;「图腾+护符」举例经 JewelCraftingRecipeLoader/JewelCraftingRecipeGeneratingCache 验证正确 |
001_feature/301_moon.md(新增) |
结构/锚点/物品 id 全部有效(#anvil-impact-crafting、#hidden-celestial-bodies、lunar_rock 等均已注册;zh 用中文锚点符合既有 44 处先例),但正/背面段落见 🔴1、返程见 |
|
002_material/140_void_matter.md |
✅ | 与 CrateBlock dispose 逻辑一致 |
002_material/210_liquid_enchantment.md |
✅(💡写法) | 配方数值精确匹配 |
004_block/001_redstone.md |
✅ | 纯措辞修正 |
004_block/002_jewelcrafting_table.md |
✅ | 「部分仿制品带诅咒」与 has_vanishing_curse 一致;合并为一行不超既有排版先例(最多 11 个/行) |
004_block/003_crate.md |
✅(💡EOF) | 三新段均与代码一致 |
004_block/215_large_crate.md |
✅(💡浮窗措辞) | 数值/合并机制均已验证 |
004_block/331_hyperdimension_storage_station.md |
✅ | 「升级过四次」为必要前置 |
004_block/401_celestial_forging_anvil.md |
✅ | 「潜行不受影响」与引力系统一致 |
004_block/402_mega_structure.md |
删除内容仍成立,见 |
|
005_tool/000_guide_book.md |
A 键/物品链接正确,但获取方式被收窄、删掉的信息仍有价值,见 |
结论: COMMENT(建议修改后合并) — 本次更新绝大部分是把手册数值与代码对齐,方向完全正确(潜影容器容量、超维存储站前置、A 键、合成窗口、分类 AND 语义、液态魔咒新配方等均已逐条核实为真)。阻塞项只有一处:新增「月面」的坐标轴/阈值与代码冲突(且「群系」表述不成立),加上月球返程与非核心方块、二次确认、珍珠返程的说明缺失,建议一并修正后合并。无 Java 变更,无序列化/注册/兼容性风险。
由 Hermes Agent 审查
|
💾 Self-improvement review: Patched SKILL.md in skill 'documentation-pr-review' (1 replacement). |
代码审查摘要 — PR #4776操作: opened(非 closed/labeled,正常审查) 🔴 关键
|
| 文档声明 | 验证来源 | 结论 |
|---|---|---|
| 指南书「悬浮后按 A 打开集成」(原 W) | ModKeyMappings.THOUGHT 默认 GLFW_KEY_A(GUI 上下文)+ GuideBookItem.onThought() → IntegrationUtil.openIntegrationScreen() |
✅ 修正正确 |
| 消失诅咒液体魔咒 = 9 诅咒金块 + 虚空物质 + 1mB;绑定诅咒 = 9 诅咒金块 + 链 + 1mB | SolidLiquidRecipeLoader L130-158 |
✅ |
| 珠宝加工台「部分仿制品带消失诅咒(不死图腾、各种护符)」 | JewelCraftingRecipe codec optionalFieldOf("has_vanishing_curse", true);图腾/护符/鞘翅无该字段=默认 true,试验钥匙/旗帜图案/唱片/陶片/锻造模板为 false |
✅ "部分"表述准确 |
| 储物箱分类显示「左击标绿、需同时满足所有条件」 | StorageServerStub 逐条遍历 CategoryEntry,任一不匹配即返回 false(AND 语义) |
✅ |
| 储物箱合成窗口「放入工作台+切石机启用;Shift 合 1 组、空格合 8 组」 | StorageServerStub.craftingAvailable(PLAYER_WORKSTATIONS_CRAFTING_TABLES + …_STONECUTTERS 标签);StorageScreen.clickCraftingResult → takeAllChunk(..., space ? 8 : 1) |
✅ |
| 潜影盒容器「约 1024 种物品 × 每种 1024 组」(原 6.5万×6.5万) | ShulkerContainerStorage = TypeLimitItemStacksResourceHandler(1024, 65536),computeCount = floorDiv(space, ceilDiv(64, maxStackSize)) → 65536 个 = 1024 组 |
✅ 旧值确实是错的 |
| 存储终端浮窗 Shift 按行 / Ctrl 按页 / Alt 放大 / Shift 左击取入背包 | TerminalRemoteOverlay L285-296(pageSize/gridSize)、L320(ALT 切尺寸)、L744(Shift → takeToInventory) |
✅ |
| 天体引力「玩家潜行时不受影响」 | GravityManager L168 / L686 entity instanceof Player player && player.isShiftKeyDown() |
✅ |
| 登月「午夜 + 极高速度向上发射末影珍珠」 | MunTravelEventListener:MIDNIGHT=18000(±1000)、Y>512、speed ≥ 32、需向上 |
✅ |
| 链接锚点与物品 ID | #anvil-impact-crafting/#铁砧撞击合成、#hidden-celestial-bodies/#隐秘天体 均存在;../006_prop/100_amulet.md 双语均存在;lunar_rock/lunar_soil/monolith/monolith_core/monolith_line/giant_monolith_* 均在 ModBlocks 注册 |
✅ |
| 中英文对称性 | 12/12 文件路径一一对应;无指向被删章节的悬空引用 | ✅ |
📋 结构核对
- 2 个新增页面(
001_feature/301_moon.md)中英成对 ✅;001_feature/index.md仅为目录说明,无需登记子页 ✅ - ghost 文件:0 ✅;被删章节无外部反向引用 ✅
结论: REQUEST_CHANGES(小改即可合并) — ?5Moon 的 § 编码错误必须修;月面坐标(1024/2048 与 X/Y→X/Z)和石碑返程(非核心 + 二次点击 + 返回重生点)两处表述建议按源码修正后再合并。其余为可选润色。
🏷 PR 标题
原标题 在手册更新内容 缺英文标题、信息量不足。建议标题:
Update handbook: add Moon page and correct outdated entries 更新手册:新增月球页并修正过时内容
gh pr edit:gh auth status 显示 /opt/data/home/.config/gh/hosts.yml 中 token 已失效(Failed to log in to github.com account Gugle2308),本流程禁止 export GITHUB_TOKEN,故无法自动改标题,请维护者手动设置或修复 gh 登录后由我更新。
由 Hermes Agent 审查
|
💾 Self-improvement review: Patched SKILL.md in skill 'documentation-pr-review' (1 replacement). · Patched SKILL.md in skill 'github-webhook-pr-review' (1 replacement). |
|
PR #4776 action 为 closed,按 Webhook 约束第 1 条:跳过审查,不发布评论。
|
No description provided.