feat(rendering): add occlusion culling backends and bindless texturing - #95
Open
ZhuRuoLing wants to merge 29 commits into
Open
feat(rendering): add occlusion culling backends and bindless texturing#95ZhuRuoLing wants to merge 29 commits into
ZhuRuoLing wants to merge 29 commits into
Conversation
ZhuRuoLing
marked this pull request as draft
August 7, 2026 21:58
…rnal to some internal api
ZhuRuoLing
force-pushed
the
feat/occusion_culling
branch
from
August 13, 2026 22:34
3c58b50 to
4cdf68c
Compare
ZhuRuoLing
changed the title
ZhuRuoLing
marked this pull request as ready for review
September 8, 2026 11:22
Reason: script execution via -e/-c flag Reply |
|
All verification complete. This is round 18 (十八复) — delta is a single commit 「SO AMD FUCK U」fixing an AMD driver issue, and the fix is incomplete (regular shader only). Writing the review: 代码审查摘要 — PR #95（十八复 / synchronize）操作: synchronize · HEAD: 🔴 关键
|
| 问题 | 行号 | 状态 |
|---|---|---|
simpleCodec(TestBloomBlock::new) codec 引用错类 |
9402 | ❌ 未修 |
getBuffer(6 * 6) + drawIndexed(0, 0, 6 * 6, 1)（QUADS 24 顶点 vs 36 索引） |
6440 / 6497 | ❌ 未修（GPU_QUERY 接线后 active） |
new AABB(worldPosition) 零尺寸盒 + inflate(0.1) |
9441 / 6805 | ❌ 未修 |
| IntSizeUbo 宽高互换（getHeight 先行） | 3324 | ❌ 未修 |
midTex = textures.get(6) SPD mid-mip 语义 |
6214 / 6250 | ❌ 未修 |
| mipmap 节流（十六复 §37 引入项） | 5200-5307 | 原样（interval 默认 0，inert） |
| GL46.* 入口点 / isSupported 恒 true / 阻塞读 / alrSetWasUsed / 提交门控死锁等 | 各处 | ❌ 未修 |
十七复 GL_KHR_shader_subgroup 探测 vs shader _quad : require、define=0 变体无条件注册、HZOC 死 import） |
— | ❌ 本轮未触碰 |
结论
REQUEST_CHANGES — 本轮 commit 的 AMD 修复方向正确（常量索引 switch + TEXTURE_FETCH_BARRIER），但只修了双变体中的一半：bindless 派发路径上动态 image 数组索引原样保留，AMD 故障在 bindless 配置下必然复现；请同步修复 bindless 变体并清理 setupTexture 死代码与启动 INFO 日志。旧 blocker（codec 错类 / 6*6 索引越界 / AABB 零尺寸 / IntSizeUbo）已跨 10+ 轮未修，建议优先处理。
gh 未认证（token invalid，401），标题未修改（现标题准确无需改）。
🌿 Roseau API Breaking Change Report
🔴 rendering — 44 breaking change(s)
|
|
💾 Self-improvement review: Patched SKILL.md in skill 'rendering-gpu-pr-review' (1 replacement). · Patched references/pr95-occlusion-culling-review-matrix.md in skill 'rendering-gpu-pr-review' (1 replacement). |
代码审查摘要 — PR #95（synchronize 复审查 · 十九复）操作: synchronize 🔴 关键（本轮新增）
|
|
💾 Self-improvement review: Patched SKILL.md in skill 'rendering-gpu-pr-review' (1 replacement). · Patched references/pr95-occlusion-culling-review-matrix.md in skill 'rendering-gpu-pr-review' (1 replacement). |
🌿 Roseau API Breaking Change Report
🔴 rendering — 44 breaking change(s)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the Minecraft 26.1 rendering module with an occlusion-culling framework and GPU-side rendering infrastructure. It adds an OpenGL samples-query backend, Hi-Z depth-processing foundations, feature-submit filtering, and compute/texture capability plumbing.
Changes
OcclusionCuller,OcclusionKey,OcclusionMethod, culling statistics, and wrapped submit-node storage.R32Fdepth conversion and FidelityFX SPD mip-chain foundations.ApiStatus.Internalplacement and sync-module imports.test_occlusionblock, block entity renderer, generated assets, and compute-test binding updates.Impact and Compatibility
ARB_bindless_texture; the regular SPD path remains available.ALRComputePassnow uses explicit bindings, lazySupplier<String>debug groups, andpopDebugGroup(); internal callers were updated.TODO