Prefer compiled RIMAPI Assemblies for the run metadata pin - #71
Closed
jkbennitt wants to merge 1 commit into
Closed
Conversation
Probe RIMAPI_DLL_PATH, then the fork checkout Assemblies (1.6/1.5), then ../RIMAPI next to the RLE git toplevel, and only then Workshop. Resolve rimapi_fork_commit via RIMAPI_FORK_PATH or git show-toplevel so site-packages installs still find a sibling checkout. Co-authored-by: Jason <jkbennitt@users.noreply.github.com>
jkbennitt
marked this pull request as ready for review
September 7, 2026 22:10
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Flash/Sep 6 keepers recorded a Steam Workshop DLL sha (
73E659E8…) with an emptyrimapi_fork_commit. AppSprout’s source of truth is the compiled AppSprout-dev/RIMAPI checkout (rle-testing), not Workshop._rimapi_dll_path()only honored$RIMAPI_DLL_PATHor a hardcoded Workshop path._rimapi_fork_commit()walkedPath(__file__).parents[3], which misses the fork when RLE is imported from site-packages /.venv.Change
Probe order for the DLL hash (first existing file):
$RIMAPI_DLL_PATH(if set but missing →None, no silent Workshop fallback)$RIMAPI_FORK_PATH/{1.6,1.5}/Assemblies/RIMAPI.dll{RLE git toplevel}/../RIMAPI/{1.6,1.5}/Assemblies/RIMAPI.dllFork commit honors
$RIMAPI_FORK_PATH, then a sibling../RIMAPIresolved viagit rev-parse --show-toplevel(cwd, then this module’s directory). Docs (README, CONTRIBUTING, CLAUDE.md,.env.example) tell AppSprout runs to set both env vars so summaries record path, sha256, and fork commit.Out of scope
No
rle-testingsync, no DLL rebuild, no billed model calls, no dependency default changes.Test plan
pytest tests/unit/test_metadata.py— 18 passedruff check/mypy src/rle/tracking/metadata.pyclean