fix: preflight gates so keeper Crashlanded failures are not model noise - #72
Merged
Merged
Conversation
…model noise Treat already-covered growing zones as success-by-state (check-zone / engine). Validate work_priority against WorkTypeDef names and stop sending id/priority as work types. Queue only available research. Require a living doctor/patient pair before tend. Hide and refuse stockpile_delete when the endpoint is missing. Co-authored-by: Jason <jkbennitt@users.noreply.github.com>
…search
Felix integration fixtures emit {"skill": "growing", "priority": 1}. Treat
skill as a WorkTypeDef alias. Re-queueing the current research project is
allowed (it is available); only finished and locked projects are blocked.
Co-authored-by: Jason <jkbennitt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jason-cleared RLE-side contract/preflight fixes. These five Crashlanded keeper failures were being scored as model noise; they are dispatch/catalog bugs, not Ilya develop gaps.
Gates
POST /api/v1/builder/check-zone(plus in-memory overlap and engine “already covers” messages) instead of retrying create.id/priorityas the payload.id/priorityare never treated as WorkTypeDef names. Acceptswork/work_type/skill+priority. Names validated against/api/v1/work-list(vanilla fallback).research.available. Finished and locked fail before the write. Re-targeting the current project is allowed (it is available).tendrequires a distinct living doctor/patient pair (doctor_pawn_id+ patient id).Approach
Harness-agnostic preflight in
rle.orchestration.preflight, called fromActionExecutor(game loop and MCP both passGameState). Catalog/brief/tool schemas updated whereid/priorityorstockpile_deletewere advertised.Tests
Unit coverage for each gate in
tests/unit/test_preflight.py. Full local suite: 710 passed. ruff + mypy + harness boundary clean.No N>1 runs and no baseline calibration.