Repository navigation
Declare runtime dependencies in pyproject.toml - #113
Merged
abearab merged 1 commit intoNov 13, 2026
Merged
Conversation
pip install ScreenPro2 installed no dependencies, so importing the package or running the screenpro CLI failed with ModuleNotFoundError. List every package the code imports, with the pins environment.yml already uses (pandas<2, matplotlib<3.7) plus the ones those pins imply (numpy<2, pydeseq2<0.5, pyarrow<26, Python <3.12). Fixes ArcInstitute#112
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates pyproject.toml to restrict the Python version to >=3.9,<3.12 and explicitly defines several package dependencies. The review feedback identifies a likely typo in the pyarrow version constraint (suggesting <16 instead of <26 to prevent compatibility issues with NumPy 2.0) and recommends replacing wildcard constraints (*) with minimum version requirements to ensure stability.
abearab
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112.
What's wrong
[tool.poetry.dependencies]lists onlypython, sopip install ScreenPro2(the README's install command) installs none of the packages the code imports.import screenproandscreenpro --helpthen fail withModuleNotFoundError: No module named 'pandas'.Fix
Declare every third-party package that
screenpro/imports, with pins taken fromenvironment.ymland from what those pins require:<2.0environment.yml<3.7environment.yml>0.20environment.yml<2.0<0.5<26ImportError: pyarrow requires NumPy 2.0 or newerat import>=3.9,<3.12I left out packages in
environment.ymlthat nothing inscreenpro/imports (seaborn, numba, igraph/leidenalg, watermark, pytest).Verification
pip install .from this branch: resolves to pandas 1.5.3, numpy 1.26.4, matplotlib 3.6.3, pydeseq2 0.4.12, pyarrow 25.0.1, scanpy 1.11.0, anndata 0.11.4, polars 2.1.0.import screenproworks,screenpro --helpprints usage, andpytest testspasses 4/4.pyarrow<26cap, pyarrow 26 gets installed and the twotest_fastq2counttests fail with the NumPy 2ImportErrorabove.Requires-Distline for each package andRequires-Python: >=3.9,<3.12.environment.ymlstill allowspython<=3.12and leaves pydeseq2 unpinned (points 1 and 2 in the issue). I kept this PR topyproject.toml, but I'm happy to alignenvironment.ymlhere or in a follow-up if you'd like.@abearab, could you take a look when you have a moment?