Fix notification ID sequence exhaustion - #1002
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notification.idandnotification_id_seqfrom 32-bit integer to bigintProduction rollout warning
Production's
notificationtable is approximately 13 GB (6.1 GB heap and 6.4 GB indexes, about 26 million rows). PostgreSQL must rewrite it while holding anACCESS EXCLUSIVElock.Coordinate a maintenance window and quiesce notification readers/writers before applying this migration. The migration uses a 5-second
lock_timeoutso an unattended deploy fails instead of leaving requests queued. After the lock is acquired,statement_timeoutis disabled so the rewrite can finish.Validation
2147483647and successfully inserted notification ID2147483648asbigintgo test -run '^$' ./api/... ./jobs/...