chore(jobs): drop volume accumulator from on-chain coin stats - #1003
Merged
Conversation
The all-time volume stat was removed from the product (unverifiable vendor figure; no other aggregator even reports it), so CoinStatsOnchainJob no longer needs to compute it. Removes the accumulator update/read logic and the volume columns from the artist_coin_stats_onchain upsert, drops the now-unused artist_coin_volume_accumulator table, and removes its seed base row. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the volume accumulator from
CoinStatsOnchainJob:updateVolumeAccumulator/readVolumeAccumulatorand stops writingtotal_volume/total_volume_usdin theartist_coin_stats_onchainupsertartist_coin_volume_accumulatortable (migration0234) and its seed base rowWhy
The all-time volume stat this fed is being removed from the product (AudiusProject/apps#14542). It's an unverifiable figure — no other aggregator (DexScreener, GeckoTerminal, Jupiter) even reports an all-time cumulative volume for these coins, the source value can't be reproduced on-chain, and for multi-market coins it aggregates pools we don't index. Rather than maintain data we won't display, we drop it.
Price, holders, market cap, liquidity, and 24h price change are unaffected. The
artist_coin_stats_onchain.total_volume*columns remain (mirrored fromartist_coin_stats) but are simply left NULL.Test
go test ./jobs/ ./database/pass; schema loads with the table removed; build/vet clean. (Schema dump edited to drop only the accumulator table — the unrelated churn frommake test-schemareflects pre-existing drift on main and is left out.)🤖 Generated with Claude Code