fix(coins): drop totalVolumeUSD from /v1/coins response and spec - #1004
Merged
Conversation
The all-time volume stat was removed from the product; stop returning it from the /v1/coins (coin) response and remove it from the swagger coin schema. The underlying artist_coin_stats.total_volume_usd column is unchanged, so the existing "volume" sort still works (it orders by the joined column). Note: this is a breaking change to the public /v1/coins response. The generated SDK Coin model must be regenerated from the served swagger after this deploys. coin_insights still exposes the field (its handler uses SELECT * and the column is still written by the Birdeye CoinStatsJob) — left for a separate change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
rickyrombo
added a commit
to AudiusProject/apps
that referenced
this pull request
Aug 4, 2026
## What Regenerates the SDK `Coin` model after AudiusProject/api#1004 removed `totalVolumeUSD` from the `/v1/coins` response — dropping the field from the interface, `CoinFromJSONTyped`, and `CoinToJSON`. ## How Ran `gen:prod` (openapi-generator against the deployed prod swagger). Verified the change is live on prod first (`/v1/coins` no longer returns the field). Scoped to `Coin.ts` only — the generator also surfaced unrelated drift in `Event`/`TrackCollaboratorNotification*` models (the committed SDK was behind prod there), which I reverted to keep this PR focused. ## Safety Backward-compatible. The field was optional and its generated deserializer already handled absence (`!exists(json, 'totalVolumeUSD') ? undefined`), so old SDK builds tolerate the missing field. The client display usage was already removed in #14542 (merged), so no source references the field. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
totalVolumeUSDfrom the/v1/coinsresponse — the Gocoinresponse struct field, itsSELECTcolumn, and thecoinschema in the embedded swagger.Why
The all-time volume stat was removed from the product (AudiusProject/apps#14542) as an unverifiable figure no other aggregator reports. Stop returning a value we don't stand behind.
Notes
/v1/coinsresponse. Because the SDK is generated from the live/v1/swagger.yaml, the generatedCoinmodel must be regenerated after this deploys (separate SDK PR).artist_coin_stats.total_volume_usdcolumn is untouched (still written by the BirdeyeCoinStatsJob), so the existingvolumesort still functions — it orders by the joined column.coin_insightsstill exposes the field: its handler usesSELECT artist_coin_stats.*+RowToStructByName, so removing it there means dropping/renaming the column or changing the query, and the column is still populated by Birdeye. Left for a separate change onceCoinStatsJobis retired.Test
go build ./api/...andgo test -run Coins ./api/pass; swagger validates as YAML.🤖 Generated with Claude Code