Improve plotting code - robustness, unification, remove code repetition - #46
Draft
keiran-rowell-unsw wants to merge 43 commits into
Draft
keiran-rowell-unsw wants to merge 43 commits into
keiran-rowell-unsw wants to merge 43 commits into
Conversation
…dles this more robusts on a per-program basis, can be source of truth
…e of plotly saving from the actual report
…meta.mode to each output
…Channel to simpligy everything
…ment by tlitfin on draft PR nf-core#574
…rated by the modules
…erased in the consolidation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plotting refactor, drops duplicate files, ~300 lines of repetition beyond files, and reads more cleanly.
Implements nf-core#484, closes nf-core#485, and inches towards nf-core#373.
Will verify this implements nf-core#363
TODO:
TESTING: