Conversation
darkdi
force-pushed
the
dup-client-id-check
branch
from
September 1, 2026 13:54
7a651d9 to
4b2a3d9
Compare
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Author
|
The bot added Needs Author Reply when the PR was opened, but its checklist is all green and nobody asked anything yet, so I think it's waiting on review rather than on me. The changelog entry is in |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
empty( $wpcc_options['client_id'] )operand from the WPCC activation guard.client_id, and a presentclient_id.patch,fixed).If the third operand was intended to check another key,
client_secretis the obvious candidate, but this repository only readswpcc_options; I did not change behavior without evidence.Related product discussion/links
Does this pull request change what data or activity we track or use?
No. It removes a duplicate boolean operand and does not change data collection, storage, transmission, or behavior.
Testing instructions
php -l projects/plugins/jetpack/class.jetpack.php.Jetpack::handle_deprecated_modules()and confirm its result is unchanged for:wpcc_options;client_id;client_id.The removed operand was identical to the preceding one, so the boolean expression has the same truth table before and after the change.