-
Notifications
You must be signed in to change notification settings - Fork 900
Premium Analytics: note adjustments in the Earnings History widget #52526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dognose24
merged 6 commits into
trunk
from
add/premium-analytics-earnings-history-adjustments-line
Sep 22, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6571b23
Premium Analytics: note adjustments in the Earnings History widget
dognose24 3534e45
Premium Analytics: put the adjustments link in the widget footer
dognose24 6a38f4d
Merge remote-tracking branch 'origin/trunk' into add/premium-analytic…
dognose24 8dcc8a3
Premium Analytics: badge the adjustments count in the widget footer
dognose24 5519c06
Premium Analytics: stand the footer badge at its full height
dognose24 4ed9663
Premium Analytics: keep the adjustment count in the badge link's name
dognose24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
...kages/premium-analytics/changelog/add-premium-analytics-earnings-history-adjustments-line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: minor | ||
| Type: added | ||
|
|
||
| Ads: Note in the Earnings History widget when the site has adjustments, linking to the Adjustments history tab of the Earnings report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
projects/plugins/jetpack/changelog/add-premium-analytics-earnings-history-adjustments-line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: minor | ||
| Type: enhancement | ||
|
|
||
| Premium Analytics: Note in the Earnings History widget when the site has adjustments, linking to the Adjustments history tab of the Earnings report. |
4 changes: 4 additions & 0 deletions
4
...ugins/premium-analytics/changelog/add-premium-analytics-earnings-history-adjustments-line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: minor | ||
| Type: added | ||
|
|
||
| Ads: Note in the Earnings History widget when the site has adjustments, linking to the Adjustments history tab of the Earnings report. |
4 changes: 4 additions & 0 deletions
4
projects/plugins/wpcomsh/changelog/add-premium-analytics-earnings-history-adjustments-line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: minor | ||
| Type: added | ||
|
|
||
| Premium Analytics: Note in the Earnings History widget when the site has adjustments, linking to the Adjustments history tab of the Earnings report. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if
Badgeshould be the link itself? We have to remove the link styling to make it fit, and@wordpress/uidescribesBadgeas a status label, not something you click.If we want it to look like a chip,
LinkButtonmay be a better fit. Right now the widget draws its own footer, but later, we will replace this with native widget actions the host draws it (WordPress/gutenberg#81740) and only usesLinkorLinkButton. cc @retrofoxThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point: nothing in the monorepo puts a
Badgeinside a link today, so this is a first. I tried a plain Adjustments link with a count badge beside it, but it reads as two things and drifts from Eder's single-chip design for this line;LinkButtonkeeps the shape but loses the intent colour.I'd like to ship this as designed and settle the component question in a follow-up with Eder and @retrofox. The change is contained (
ReportLinkonly gained achildrenslot), so swapping toLinkorLinkButtonlater is a small local change. I'll open the follow-up and link it here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up opened: WOOA7S-2194.