Boost: Hide footer links when My Jetpack is unavailable - #52557
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Backup plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Search plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Social plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Starter Plugin plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Protect plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Videopress plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Classic Theme helper plugin plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Stats Data plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 3 files.
|
f452e5f to
61a699f
Compare
Fixes BOOST-745
Proposed changes
Hide Products and Help in React and PHP footers unless My Jetpack confirms initialization, page registration, and user access. Preserve existing host restrictions and custom links.
Related product discussion/links
No additional links.
Does this pull request change what data or activity we track or use?
No.
Testing instructions
With SCRIPT_DEBUG=false, inspect the pages below. Offline mode or disabling My Jetpack initialization should hide both links. Restoring availability should show them.
Components and consumer JavaScript suites, Boost/My Jetpack PHP suites, 15 footer PHP tests, ESLint, PHPCS, compatibility checks, and My Jetpack/Jetpack Phan passed locally.
The full Jetpack PHP suite has one Related Posts failure, reproduced on trunk.
Docker used local connection fixtures; fully connected WordPress.com navigation was not exercised. Available and offline screenshots cover 1280, 782, and RTL: