Boost: walkthrough integration build (do not merge) - #52559
Draft
LiamSarsfield wants to merge 89 commits into
Draft
LiamSarsfield wants to merge 89 commits into
LiamSarsfield wants to merge 89 commits into
Conversation
…vering all five new uncovered lines. Fixed both Boost e2e failures by asserting focus on the popover container. Verified 14 Jest tests, 9 Chromium fixture tests, lint and formatting. Confirmed regressions fail before fixes. Full WordPress CI matrix was not rerun locally
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
The empty-day popover now uses the recorded-day 12px date gap, so the one-line and two-line popovers measure 265x86 and 265x106 as designed. The points info icon turns blue whenever the points popover is open, including when the "+N points" badge opened it.
LiamSarsfield
force-pushed
the
fm/duo-walkthrough-integration-build
branch
from
September 22, 2026 18:54
7642a6b to
f76b249
Compare
The docblock named the Jetpack plugin owning the parent menu as the trigger. Core's condition is that nothing registered the parent at all. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wr8mRdCF1srgLG5W4g9zUP
Keeping the product-name note in its own PHP block emitted the block's indentation twice in a row, which PhanPluginDuplicateAdjacentStatement flags. Fold it back into the block above, separated by a blank line. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019svoMpcVk128YhErbnqPUr
# Conflicts: # projects/plugins/jetpack/_inc/lib/admin-pages/class.jetpack-admin-page.php
# Conflicts: # projects/plugins/boost/app/assets/src/js/features/page-cache/meta/meta.test.tsx # projects/plugins/boost/app/assets/src/js/features/page-cache/meta/meta.tsx
# Conflicts: # projects/plugins/boost/app/assets/src/js/features/cornerstone-pages/prerender/prerender.tsx # projects/plugins/boost/app/assets/src/js/features/page-cache/meta/meta.tsx
# Conflicts: # projects/plugins/boost/_inc/overview/history-chart-card.scss
# Conflicts: # projects/plugins/boost/app/assets/src/js/pages/settings/settings.test.tsx
LiamSarsfield
force-pushed
the
fm/duo-walkthrough-integration-build
branch
from
September 22, 2026 20:55
bd3aa53 to
cab76ff
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway integration build of the open dashboard PRs for a UI walkthrough. Not for merge; it will be closed once the walkthrough is done.
Rebuilt on 2026-09-22 from trunk
faa7dc3bd2f4b7707f5255a625006730ffa7fc76, merging these heads in order:ac827f1bc381fd0ee0c75431521b78e83e20d8c03e4ebd2838d50a7abfdc08ee9417de5b66618370265a33168437de3aa60700bf14f93a311664bc38675e6fd6cb7d5e28c96352cd9f03f805beb2f24962fbcea594c716ebdc5ed6d70bcee88a72a9ec2277138cd246ed43b2eb98a7af22055c9c1a21554b694fdbedc7fb48f03a77e434db2ceb4208910c8edb820aebd6b8ffc80d10beabd901db69e89bebed0309edd949f33836625d890076e4e9d405574d70522efe0093405be9b03974db83c13d6ee4b6d57b540524feb136b524fecf8757e242d479b765f17e69184fc5b7d60a9cdbebb05146fa7a8a91fe0431d54f6f687179e2d52cb9bcea64619f2511f2789ae988ccd9d6a290ce0a9fce6c061d2acc7ef6019ec1c30bc876ce361dd430280a4a5797fe334c0d8e0b598c9a2d9c8e61029bf9c29c2c8ec1e71a32e0ea774d3fdd2f3e03741068674cfd1519fcde312142bacfa38c2e5d4079be54ed56d3e8d3bb5b44b0017cea40003d9d300187081a578536f2527ba2b3b49d8252aabc330af8ee446781eb0b25cb02765c5e06dd6537b0802f50705bc402118e3b61840e85#52610 is closed and is no longer included; the Overview keeps the existing score bands (good above 70, medium above 50).
Conflicts, each resolved from the two sides:
page-cache/meta/meta.tsxandprerender.tsx(52642, 52643): imports from both sides, and the tooltip trigger is the design-system link element carrying the keyboard ref, role and handlers. Both sides addedmeta.test.tsx, so the tooltip tests stay there and the Page Cache well tests are inmodern-meta.test.tsx.history-chart-card.scss(52646 after 52547): took the 52646 side for the popover tooltip rules, which cover the empty-day box, and kept 52547's neutral chevron tokens, its bar class selectors and the pointer-events media query.settings.test.tsx(52629 after 52624): kept both new tests; the h3 test includes the Cornerstone description that 52624 renders in the header.Validation: Boost Jest 568 tests, charts 1688 tests and components 127 tests passed; the production Boost build with dependencies passed.