Repository navigation
feat(boost): add Critical CSS info tooltip to modern Settings - #52612
Merged
Merged
Conversation
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
LiamSarsfield
marked this pull request as draft
September 22, 2026 10:01
Code Coverage SummaryCoverage changed in 1 file.
|
LiamSarsfield
marked this pull request as ready for review
September 22, 2026 11:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of BOOST-746
Proposed changes
Add the shared info icon immediately after the Critical CSS title on modern Settings. Its single translated tooltip reads: “Critical CSS is the small set of styles needed to show the top of each page. Boost loads it first so pages appear faster while the rest of the CSS loads.”
Related product discussion/links
No separate ticket.
Does this pull request change what data or activity we track or use?
No.
Testing instructions
Enable
rsm_jetpack_ui_modernization_boost, open Boost Settings, enable manual Critical CSS, and open the info icon.Chrome captures cover 1280/782 pixels, LTR/RTL. The 1280 LTR capture matches the September Critical CSS state sheet’s icon-after-title placement. Intentional differences: existing shared icon size/color/spacing instead of custom frame styling; tooltip shown open; local manual/generated state with an existing partial-failure notice, whereas the full paid frame shows automatic generation without this title/icon. Other well differences are unchanged.
With modernization disabled, legacy dashboard HTML is byte-identical and screenshots have zero differing pixels; CSS adds only the modern icon rule.
Jest: 512 tests pass. TypeScript, ESLint and Prettier pass. PHP: 209 tests pass; the WordPress suite lacks local WorDBless. Phan reports two pre-existing findings outside this change. Boost e2e specs cannot run here; Docker browser checks supply visual evidence.
Shared trigger naming and mouse-only behavior stay unchanged: keyboard activation is covered by #52538; accessible naming is a separate shared-component follow-up.