Content Guidelines: Fix AI button alignment and loading shimmer after Gutenberg changes by aagam-shah · Pull Request #52764 · Automattic/jetpack

aagam-shah · 2026-09-24T13:06:24Z

Fixes #

Proposed changes

Recent Gutenberg changes broke two things on the Guidelines page:

Button order. Fix: Content Guidelines: UX/UI Accessibility issues WordPress/gutenberg#80306 changed the section buttons from left-aligned [Save] [Clear] to right-aligned [Clear] [Save]. Our Generate/Improve button now shows to the right of Save. When Save is last in the row, we now add our button first. Otherwise, we add it last as before. This works on old and new Gutenberg.
Loading shimmer. UI: Add ValidatedTextArea control WordPress/gutenberg#81984 moved the DataForm textarea to @wordpress/ui. It no longer has the .components-textarea-control class, and a wrapper draws the border, so the shimmer and green border stopped showing. We now also target the textarea's wrapper. The old selector still works for older Gutenberg and the block modal.
Diff position. Gutenberg 24.0 shows the field label, but we hid the whole DataForm while a suggestion is active, so the diff jumped up. Now the diff sits after the DataForm and only the textarea box is hidden. The diff also matches the new textarea's height, line height, and padding.
On newer Gutenberg, shorten the section button to "Generate" / "Improve" to match the bare "Clear" and "Save" next to it. Older Gutenberg keeps "Generate guidelines" / "Improve guidelines".
In sections, align Accept suggestion and Dismiss like the Save/Clear row: right-aligned with Accept last on new Gutenberg, left-aligned with Accept first on older Gutenberg. The block guideline modal keeps its left-aligned row.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

Sync this branch to a site with Jetpack AI and the latest Gutenberg. Go to Settings → Guidelines.
Each section should show [Improve] [Clear] [Save], right-aligned. An empty section shows "Generate".
Click it. While it loads, the textarea should have a green border and a moving shimmer.
When the suggestion shows, the field label should stay, and the diff should sit exactly where the textarea was.
The row should be [Dismiss] [Accept suggestion], right-aligned. Accept or dismiss it, and the generate button comes back in the same place.
Open "Add block guideline", pick a block, and generate. The shimmer should show, and [Accept suggestion] [Dismiss] should stay left-aligned, as before.
On a site with older Gutenberg, the section row should stay [Save] [Clear] [Improve guidelines], [Accept suggestion] [Dismiss] should be left-aligned, and the shimmer should still show.

🤖 Generated with Claude Code

github-actions · 2026-09-24T13:07:38Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/content-guidelines-ai-section-button-order branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/content-guidelines-ai-section-button-order

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2026-09-24T13:08:09Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: October 6, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2026-09-24T13:17:51Z

Code Coverage Summary

Coverage changed in 3 files.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/jetpack/_inc/content-guidelines-ai/lib/inject.js	0/119 (0.00%)	0.00%	2 ❤️‍🩹
projects/plugins/jetpack/_inc/content-guidelines-ai/components/suggestion-actions.jsx	34/35 (97.14%)	0.27%	0 💚
projects/plugins/jetpack/_inc/content-guidelines-ai/lib/dom.js	13/13 (100.00%)	0.00%	0 💚

Full summary · PHP report · JS report

saroshaga · 2026-09-25T13:49:05Z

 	const isEmpty = ! useSectionHasDraft( slug );
-	const generateLabel = __( 'Generate guidelines', 'jetpack' );
-	const improveLabel = __( 'Improve guidelines', 'jetpack' );
+	const generateLabel = isShortLabel


I'm wondering if this is actually worth doing? I'd keep "Generate guidelines" / "Improve guidelines" on all versions. It's the one AI action in the row, so the longer label is clearer, and it avoids the label changing depending on the Gutenberg version.

This is how weird it looks:

Gutenberg now right-aligns the section row as [Clear][Save]. Insert the Generate/Improve button first in that layout so Save stays rightmost, and keep appending it on older Gutenberg's left-aligned [Save][Clear] row. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Match Gutenberg's action rows: right-aligned with the primary button last, in both the section panel and the block guideline modal. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Gutenberg now renders DataForm's textarea with @wordpress/ui, which drops the .components-textarea-control class and draws the border on a wrapper. Target the textarea's wrapper too, so the shimmer and green border show. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Gutenberg 24.0 shows the section field label, and 23.9 moved the textarea to @wordpress/ui. Place the diff after the DataForm and hide only the textarea box, measure the bordered wrapper, and match its line height and padding. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Inject the suggestion container right after the textarea box, inside the field, and hide the box before it. This removes the extra gap under the label and works the same on old and new Gutenberg. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

offsetHeight rounds 94.58px up to 95px. Use getBoundingClientRect so the diff matches the bordered box exactly. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Before 24.0, Gutenberg left-aligns the section's [Save][Clear] row. Match it when Save is the first button in that row. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

The modal's Generate button is left-aligned, and Accept/Dismiss replace it in the same row, so keep that row as it was. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Match the section's Save/Clear row: older Gutenberg left-aligns [Save][Clear], so show [Accept suggestion][Dismiss] left-aligned there. Set the order in the markup so tab order matches what users see. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Newer Gutenberg's section row has bare "Clear" and "Save" buttons, so label ours "Generate" or "Improve" there. Older Gutenberg keeps the full labels. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Use plain __() so the short labels share the translations Jetpack already has for other AI buttons. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Terser folded the two __() calls in each label ternary into one call with a conditional msgid, which the i18n check rejects. Add a dummy argument to one call so the calls differ. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

- Check the Save row once in inject.js and pass it to both components, so Accept/Dismiss order is right on first render and uses the same check. - Find the textarea box by class, the same way the CSS does. - Wrap :has() selectors in :is(), so browsers without :has() keep the rest of each selector list (the minifier merges rules into lists). - Apply the diff text override only to the @wordpress/ui textarea. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

The @wordpress/ui textarea uses 16px text below 600px to avoid mobile zoom. Do the same in the diff, and shorten the shimmer comment. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Copilot

Copilot review overview

🟢 Approval recommended

The compatibility logic matches the referenced Gutenberg DOM changes and is covered by targeted tests.

Review effort: Balanced
Findings: None

Resolved since last review (3)

Match responsive textarea font size and line height
Use textarea styles for collapsed accordion height fallback
Shorten comment to match repository conventions

aagam-shah added [Status] In Progress [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug labels Sep 24, 2026

aagam-shah self-assigned this Sep 24, 2026

aagam-shah changed the title ~~Content Guidelines: Keep Save at the edge of the section button row~~ Content Guidelines: Fix AI button alignment and loading shimmer after Gutenberg changes Sep 25, 2026

github-actions Bot added the [Tests] Includes Tests label Sep 25, 2026

saroshaga reviewed Sep 25, 2026

View reviewed changes

aagam-shah and others added 11 commits September 28, 2026 14:32

Content Guidelines: Right-align Accept suggestion and Dismiss

0faa492

Match Gutenberg's action rows: right-aligned with the primary button last, in both the section panel and the block guideline modal. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Content Guidelines: Match the textarea box height without rounding

4186f8e

offsetHeight rounds 94.58px up to 95px. Use getBoundingClientRect so the diff matches the bordered box exactly. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Content Guidelines: Left-align Accept/Dismiss on older Gutenberg

3c087ba

Before 24.0, Gutenberg left-aligns the section's [Save][Clear] row. Match it when Save is the first button in that row. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Content Guidelines: Keep block modal Accept/Dismiss left-aligned

3e2d664

The modal's Generate button is left-aligned, and Accept/Dismiss replace it in the same row, so keep that row as it was. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Content Guidelines: Reuse existing Generate/Improve translations

52fa77c

Use plain __() so the short labels share the translations Jetpack already has for other AI buttons. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

aagam-shah force-pushed the fix/content-guidelines-ai-section-button-order branch from e876577 to 52fa77c Compare September 28, 2026 09:15

aagam-shah and others added 2 commits September 28, 2026 15:14

aagam-shah requested a balanced review from Copilot September 28, 2026 10:33

Copilot started reviewing on behalf of aagam-shah September 28, 2026 10:33 View session

This comment was marked as outdated.

Sign in to view

Content Guidelines: Match the textarea text size on small screens

8662250

The @wordpress/ui textarea uses 16px text below 600px to avoid mobile zoom. Do the same in the diff, and shorten the shimmer comment. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

aagam-shah requested a balanced review from Copilot September 28, 2026 10:43

Copilot started reviewing on behalf of aagam-shah September 28, 2026 10:44 View session

Copilot AI reviewed Sep 28, 2026

View reviewed changes

aagam-shah marked this pull request as ready for review September 28, 2026 12:52

aagam-shah merged commit 577205a into trunk Sep 28, 2026
86 checks passed

aagam-shah deleted the fix/content-guidelines-ai-section-button-order branch September 28, 2026 13:02

github-actions Bot removed the [Status] In Progress label Sep 28, 2026

github-actions Bot added this to the jetpack/16.3 milestone Sep 28, 2026

Navigation Menu

Content Guidelines: Fix AI button alignment and loading shimmer after Gutenberg changes - #52764

Content Guidelines: Fix AI button alignment and loading shimmer after Gutenberg changes#52764
aagam-shah merged 14 commits into
trunkfrom
fix/content-guidelines-ai-section-button-order

aagam-shah commented Sep 24, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 24, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 24, 2026

Uh oh!

jp-launch-control Bot commented Sep 24, 2026 •

edited

Loading

Uh oh!

saroshaga Sep 25, 2026

Uh oh!

aagam-shah Sep 28, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

aagam-shah commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026

Uh oh!

jp-launch-control Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

saroshaga Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

aagam-shah Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aagam-shah commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

jp-launch-control Bot commented Sep 24, 2026 •

edited

Loading