Skip to content

Verbum comments: prevent theme styles from breaking the frequency toggle - #52856

Open
arcangelini wants to merge 1 commit into
trunkfrom
fix/verbum-frequency-toggle-theme-css
Open

arcangelini wants to merge 1 commit into
trunkfrom
fix/verbum-frequency-toggle-theme-css

Conversation

@arcangelini

Copy link
Copy Markdown
Member

Proposed changes

  • Follow-up to Verbum comments: prevent theme label styles from breaking the email form fields #52840. The new posts frequency toggle (Instantly, Daily, Weekly) is still broken on Fusion when replying to a comment. The option spans have the class text, and Fusion's li.comment .details .text rule gives them min-height: 64px, a top margin and a background image. The options grow taller than the toggle and overlap "Email me new comments".
  • Add all: unset to the span rule, the same reset the label wrapper and radio inputs already use. The padding, border and checked styles come from more specific selectors, so they still apply.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • On a WordPress.com Simple site with this change applied, switch the theme to Fusion.
  • Open a post that has comments, click Reply on a comment, and turn on "Email me new posts".
  • Before: the Instantly, Daily and Weekly options are tall, show a grey strip on top, and overlap "Email me new comments".
  • After: the options sit in a single 36px row and selecting one highlights it.
  • Repeat on a default theme (e.g. Twenty Twenty-Four) and check that the toggle looks the same as on trunk.

@arcangelini arcangelini added [Status] Needs Review This PR is ready for review. [Type] Bug labels Sep 28, 2026
@arcangelini arcangelini self-assigned this Sep 28, 2026
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the fix/verbum-frequency-toggle-theme-css branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/verbum-frequency-toggle-theme-css

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions Bot added [mu wpcom Feature] Verbum Comments Verbum, a better comment experience, app developed in the mu-wpcom plugin [Package] Jetpack mu wpcom WordPress.com Features labels Sep 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control

jp-launch-control Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[mu wpcom Feature] Verbum Comments Verbum, a better comment experience, app developed in the mu-wpcom plugin [Package] Jetpack mu wpcom WordPress.com Features [Status] Needs Review This PR is ready for review. [Type] Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant