VideoPress: Remove "Save as new video" from the trim and cut editor - #52857
Conversation
The copy job behind it fails on every production run, so saving now always updates the current video. The save dialog becomes a plain confirmation, and the copy REST routes and XML-RPC methods go with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Videopress plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
Code Coverage SummaryCoverage changed in 4 files.
|
The removed copy tests were the only ones reaching xmlrpc_methods(), the signed-user branch of create_media_item(), and the missing-owner branch of the edits permission check. Test that behavior on its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Phan flags null against xmlrpc_methods()'s WP_User parameter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixes: N/A
Proposed changes
The trim and cut editor added in #52515 lets you save edits to the current video or as a new video. Saving as a new video doesn't work in production: the WordPress.com job that copies the original fails every time, so the request sits at "processing" until it's marked as failed. Saving to the current video uses a different path and works.
Instead of rebuilding the copy job, this PR removes the option. Saving always updates the current video, and the original can still be restored.
edits/copyREST proxy routes and the XML-RPC methods WordPress.com called to create the copy's attachment (jetpack.createVideoPressCopy,jetpack.authorizeVideoPressCopy).class-xmlrpc.phpis back to what it was before VideoPress: Add trim and cut editor with save destinations #52515.The editor is behind the
jetpack_videopress_trim_cutfilter (off by default), so only testers have seen the option. The WordPress.com side of the copy flow will be removed separately.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
On a connected site, enable the editor, for example in an mu-plugin:
Screenshots
Captured on a local site with the editor enabled and
/wp/v2/mediaand the edits endpoints mocked.Automated: the copy-flow tests are removed with the code. The save test now also checks the confirmation text.
🤖 Generated with Claude Code