Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Videopress plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 6 files. Only the first 5 are listed here.
1 file is newly checked for coverage.
|
…orientation # Conflicts: # projects/packages/videopress/src/client/block-editor/blocks/video/components/player/test/index.test.tsx
Proposed changes
Portrait VideoPress videos can be rendered inside a landscape box because the host uses cached oEmbed dimensions or a 16:9 fallback. Use the saved
videoRatiowhen rendering iframe markup, and update inline and editor wrappers when the player reports its intrinsic dimensions.Related product discussion/links
VIDP-383. Requires a player bundle exposing
api.info.dimensions,api.info.onDimensionsChanged, and the corresponding iframe protocol for live corrections. Saved-ratio rendering works independently.Does this pull request change what data or activity we track or use?
No. Uses dimensions already available to the player; no additional metadata request or tracking.
Testing instructions
Validation completed:
edit.tsxline coverage rises from 0% to 42.38%.2BlxnlwPchanged from a 16:9 wrapper to 270×480 before media loaded (readyState: 0, time zero), and remained correct through playback. Two instances both received the portrait ratio.ChV25VLRremained landscape at 270×152.xhrerror, also reproduced with the unchanged boot script. Wrapper sizing was verified; duplicate playback is a separate existing issue.94da644b3d0). Local Phan requires the unavailable PHPastextension.This changes host sizing only; it does not rotate served media or repair stored source metadata.