Skip to content

PayPal Payment Buttons: Untick the address checkbox when shipping goes off - #53092

Merged
millerf merged 1 commit into
trunkfrom
fix/paypal-shipping-address-follows-shipping-toggle
Oct 2, 2026
Merged

millerf merged 1 commit into
trunkfrom
fix/paypal-shipping-address-follows-shipping-toggle

Conversation

@millerf

@millerf millerf commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Fixes WOOPTP-579

Proposed changes

  • Turning Add shipping off hid the Collect shipping address checkbox but left it ticked, so the next save kept sending collect_shipping_address: true. PayPal stored it and buyers were asked for a shipping address the seller could no longer see or turn off.
  • The shipping toggle now owns the checkbox: turning shipping off resets it with the shipping mode and fees.
  • The one exception is a tax taken from the PayPal profile, which PayPal rejects without an address. In that case the address stays collected, as the (locked) checkbox already says.
  • Not covered here: switching the tax back from profile to a specific rate while shipping is off also leaves the address collected. That is a smaller variant of the same gap and can follow separately.

Related product discussion/links

  • WOOPTP-579, part of the certification audit in WOOPTP-569.

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • Connect a site to PayPal (sandbox is fine) and add a PayPal Payment Buttons block with a saved payment link.
  • In the block form, tick Add shipping, tick Collect shipping address, then untick Add shipping. Update the post.
  • Open the published page and go through the button's checkout: PayPal no longer asks for a shipping address. Before this change it did.
  • Tick Add tax and pick the tax type that takes the rate from your PayPal settings, so the address checkbox is locked on. Now toggle Add shipping on and off: the save still succeeds (PayPal would reject it without the address).

🤖 Generated with Claude Code

…s off

Turning "Add shipping" off hid the "Collect shipping address" checkbox but
left it ticked, so the next save kept sending collect_shipping_address: true
and buyers were asked for an address the seller could no longer see or turn
off. The shipping toggle now owns the checkbox and resets it with the fees,
except under a profile tax, which PayPal rejects without an address.

Fixes WOOPTP-579.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/paypal-shipping-address-follows-shipping-toggle branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/paypal-shipping-address-follows-shipping-toggle

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions Bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Paypal Payment Buttons [Tests] Includes Tests labels Oct 2, 2026
@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: October 6, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Paypal Payment buttons plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@millerf
millerf marked this pull request as ready for review October 2, 2026 12:44
@millerf
millerf merged commit 46d8899 into trunk Oct 2, 2026
82 of 83 checks passed
@millerf
millerf deleted the fix/paypal-shipping-address-follows-shipping-toggle branch October 2, 2026 12:44
@github-actions github-actions Bot added [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. and removed [Status] In Progress labels Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Paypal Payments [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Paypal Payment Buttons [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant