PayPal Payment Buttons: Untick the address checkbox when shipping goes off - #53092
Conversation
…s off Turning "Add shipping" off hid the "Collect shipping address" checkbox but left it ticked, so the next save kept sending collect_shipping_address: true and buyers were asked for an address the seller could no longer see or turn off. The shipping toggle now owns the checkbox and resets it with the fees, except under a profile tax, which PayPal rejects without an address. Fixes WOOPTP-579. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Paypal Payment buttons plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Fixes WOOPTP-579
Proposed changes
collect_shipping_address: true. PayPal stored it and buyers were asked for a shipping address the seller could no longer see or turn off.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
🤖 Generated with Claude Code