Repository navigation
Keep reader replies out of the comments feed - #3911
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3910
Proposed changes:
ap_post. The admin already hides them, but the comments feed and the comment widgets did not. Now they skip them too.Comment::comment_feed_where()leaves out comments on the post types fromhide_for(). It uses a subquery oncomment_post_ID, because the feed of a single post has no posts join. It also applies withtype=all.widget_comments_argscallback leaves out the same post types in the Recent Comments widget and the Latest Comments block, unless the caller sets its ownpost_type.Other information:
Testing instructions:
/comments/feed: the reply is not listed.Changelog entry
Changelog Entry Details
Significance
Type
Message
Replies to posts from accounts you follow no longer show up in your comments feed and comment widgets.
The entry is already part of the branch.