chore: update package manager version and enhance pnpm detection in init command - #19
Conversation
…nit command - Updated package manager version in package.json template from pnpm@11.10.0 to pnpm@10.33.4. - Improved pnpm detection and installation prompt in the init command, including better error handling and recovery instructions for users.
- Modified the Node.js version matrix in the CI configuration to include versions 20, 22, 24, and 26, removing version 16.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fa77727. Configure here.
| matrix: | ||
| operating-system: [macos-latest, ubuntu-latest] | ||
| node-version: [16, 18, 20, 22, 24] | ||
| node-version: [20, 22, 24, 26] |
There was a problem hiding this comment.
Dead Node 16 CI branch
Low Severity
The install step still special-cases Node 16, but the matrix no longer includes 16, so that branch never runs. The leftover eslint@8 install and .eslintrc copy are now dead code after the version list change.
Reviewed by Cursor Bugbot for commit fa77727. Configure here.
| } catch (err) { | ||
| printer.error(err && err.message ? err.message : String(err)); | ||
| printPnpmRecovery(dir); | ||
| } |
There was a problem hiding this comment.
Recovery shown for unrelated failures
Low Severity
printPnpmRecovery is reused when pnpm install or pnpm dev fails. Those failures are often network, dependency, or a normal Ctrl+C stop, not a Corepack load problem, so users get Corepack/Node upgrade steps after a successful scaffold or a stopped dev server.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit fa77727. Configure here.
1 participant
Note
Medium Risk
Changes first-run scaffolding and package-manager tooling paths; CI no longer exercises Node 16/18 while a Node 16-only install branch remains in the workflow.
Overview
Aligns the scaffold and CI with Node 20+ and a pinned pnpm 10.33.4 (down from pnpm 11 in the monorepo template), with
engines.pnpmbumped to>=10.koapp initnow drives pnpm through a sharedsrc/cli/pnpmhelper: it reads the templatepackageManagerpin, runs probes/install/dev with Corepack-friendly env (no download prompt, default npmmirror registry), installspnpm@<pin>globally when needed, detects Corepack VM load failures, and prints recovery steps instead of exiting abruptly on install failures. CI drops Node 16/18 and adds 26 in the test matrix.Unit tests cover pin parsing,
corepackEnv, Corepack error detection, and the global install command.Reviewed by Cursor Bugbot for commit fa77727. Bugbot is set up for automated code reviews on this repo. Configure here.