adding preptask sample - #266
Open
Manish Sharma (manishshar) wants to merge 22 commits into
Open
Conversation
Contributor
|
Code LGTM. Could you add some details on the sample to the README Thematically I think it would make sense to swap this to sample3 and move that current sample 3 to 4 mainly due to complexity but I'll leave that discretion to Alina Park (@alfpark) and Matthew Christopher (@matthchr) |
Author
|
Thanks for your response. Thanks |
Author
|
Hi -Manish |
Brandon Klein (bgklein)
suggested changes
Apr 15, 2019
Contributor
|
Alina Park (@alfpark) / Matthew Christopher (@matthchr) / darylmsft (@darylmsft) I don't have ownership of this repo. If one of you could take a final look and merge/make any last suggestions that would be great |
Brandon Klein (bgklein)
approved these changes
May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a sample preparation task for batch samples.
Thanks
Manish